Last modified: 2008-08-01 16:43:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16995, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14995 - Arrows pointing to sections in page histories don't work due to changes in Linker class
Arrows pointing to sections in page histories don't work due to changes in Li...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.14.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Special:...
:
: 14996 15001 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-01 00:20 UTC by Titoxd
Modified: 2008-08-01 16:43 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Titoxd 2008-08-01 00:20:25 UTC
The "→" arrows that serve as anchors for sections edited using section editing (pardon the redundant redundancy) changed behavior after the latest scap. Now, instead of anchoring to a particular section, they point to the top of the page; that is, they don't append #{{SECTIONTITLE}} as they used to do.

Occurs on [[Special:RecentChanges]], [[Special:Contributions]] and article histories WikiMedia-wide. The →'s in diffs now only point to "http://en.wikipedia.org/wiki/", without even appending the page title.
Comment 1 Titoxd 2008-08-01 00:28:40 UTC
*** Bug 14996 has been marked as a duplicate of this bug. ***
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-08-01 00:29:29 UTC
This is probably my fault.  Looking into it.
Comment 3 Alex Z. 2008-08-01 00:39:46 UTC
bug 14997 seems to have been caused by the same revision (r38254)
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-08-01 00:48:19 UTC
Fixed in r38325.  Looking at bug 14997 now.
Comment 5 Chris Eagle 2008-08-01 01:16:25 UTC
Reopening. Mostly fixed, but there's still a problem with links from diffs: they now point to http://en.wikipedia.org/wiki/#Section.
Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-08-01 01:47:18 UTC
Fixed in r38330.
Comment 7 Alex Z. 2008-08-01 02:37:27 UTC
Still not working correctly, it doesn't seem to be encoding the section name in the links, 

http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(miscellaneous)#WTF? (link from edit summary) should be http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(miscellaneous)#WTF.3F (link from table of contents)

and http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Reflist%20with%202%20columns (edit summary link) should be http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Reflist_with_2_columns (TOC link)
Comment 9 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-08-01 14:41:21 UTC
(In reply to comment #7)
> Still not working correctly, it doesn't seem to be encoding the section name in
> the links, 

Rotem fixed this in r38356.

(In reply to comment #8)
> Links from diffs are broken again: they're now linking to the diff itself:
> e.g. section edit link from
> http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&diff=229221105&oldid=229218798
> points to
> http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&diff=229221105&oldid=229218798#Section%20link%20in%20edit%20summary%20broken

It's done that for a long time, if you show the revision content below the diff.  It seems to be behaving correctly except that the fragment is wrong due to not being escaped right, which is now fixed.  Marking FIXED again.
Comment 10 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-08-01 16:40:53 UTC
*** Bug 15001 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links