Last modified: 2014-11-17 10:35:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13466 - Design of diffs should be improved to indicate white space changes better
Design of diffs should be improved to indicate white space changes better
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
wikidiff2 (Other open bugs)
unspecified
All All
: Normal enhancement with 4 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: design
: 286 1208 3894 (view as bug list)
Depends on: 4012
Blocks: rtl 70163 349
  Show dependency treegraph
 
Reported: 2008-03-21 08:49 UTC by Huji
Modified: 2014-11-17 10:35 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
green highlighted line on right should show added spaces at end, does not (53.60 KB, image/png)
2011-10-07 22:28 UTC, Sumana Harihareswara
Details

Description Huji 2008-03-21 08:49:25 UTC
When two lines only differ in white spaces, this difference is not hilighted good enough. One would expect the white space(s) to be rendered with a (say) red background on the side where it exists (or, maybe, on the side it is omitted).
Comment 1 Niklas Laxström 2008-03-21 11:49:18 UTC
Should be better after r32282.
Comment 2 Niklas Laxström 2008-04-16 19:55:33 UTC
*** Bug 286 has been marked as a duplicate of this bug. ***
Comment 3 Niklas Laxström 2008-04-16 19:56:48 UTC
*** Bug 1208 has been marked as a duplicate of this bug. ***
Comment 4 Aaron Schulz 2008-04-19 05:52:14 UTC
http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28proposals%29&curid=3706897&diff=206582971&oldid=206580490

Some of these diffs look like crap. Kinda painful to look at ;)
Comment 5 Niklas Laxström 2008-04-19 08:22:03 UTC
Yeah it doesn't look so nice with long changes inside one line, because it adds the border unlike for totally new or removed lines. Have to find suitable compromise between highlighting short whitespace changes and not overhighlighting long changes.
Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-04-22 02:11:16 UTC
Aaron reverted this in r33580.
Comment 7 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-04-22 02:28:30 UTC
Maybe a different background color would be more attractive than a dotted border?
Comment 8 Niklas Laxström 2009-08-13 08:46:09 UTC
The whitespace still needs to be mungled to prevent collapsing it.
Comment 9 Sumana Harihareswara 2011-10-07 22:28:34 UTC
Created attachment 9189 [details]
green highlighted line on right should show added spaces at end, does not

Not sure whether http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28proposals%29&curid=3706897&diff=206582971&oldid=206580490 still shows the problem Aaron was pointing to.  However, https://en.wikipedia.org/w/index.php?title=User%3ASumanah&action=historysubmit&diff=454459831&oldid=454452518 does (I believe) demonstrate the problem; screenshot attached.
Comment 10 Sumana Harihareswara 2011-10-07 22:30:38 UTC
Still an issue in 1.18.

Added "design" keyword - would appreciate some design thinking on how to, as Niklas summarizes in comment 5, "find suitable compromise between highlighting short whitespace changes and not overhighlighting long changes."
Comment 11 Nemo 2012-01-22 18:56:24 UTC
*** Bug 3894 has been marked as a duplicate of this bug. ***
Comment 12 Nemo 2012-01-30 15:31:34 UTC
Moving under wikidiff2 per bug 13462 comment 7, although Nikerabbit says «dwdiff can use delimeters, that's not quite character level diff, [...] the algorithms are probably very different».
Comment 13 Amir E. Aharoni 2012-03-20 21:07:56 UTC
I suppose that this blocks bug 745, the tracker for RTL bugs, because it also doesn't clearly display changes in characters like RLM/LRM. Whoever resolves this should also consider showing emphasizing these characters somehow.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links