Last modified: 2008-03-20 21:48:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15448, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 13448 - Upload form w/o wpDestFileWarningAck generates error in upload.js
Upload form w/o wpDestFileWarningAck generates error in upload.js
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-03-20 10:12 UTC by Lupo
Modified: 2008-03-20 21:48 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Lupo 2008-03-20 10:12:31 UTC 
The recent changes in SpecialUpload.php in revision 32077 have made the wpDestFileWarningAck hidden input disappear. I don't know if that isn't needed anymore, but in any case this generates a Javascript error in /skins-1.5/common/upload.js, line 102.

And while we're at it, line 99 of upload.js is missing a ';'. Instead of

if ( warning == '' || warning == '&nbsp' ) {

it should read

if ( warning == '' || warning == ' ' ) {
Comment 1 Raimond Spekking 2008-03-20 10:47:40 UTC 
ID readded with r32217.

I leave this bug open because I am unsure if '&nbsp' is an typo or intent.
Comment 2 Lupo 2008-03-20 11:15:42 UTC 
It's an error. The server (see function ajaxGetExistsWarning in SpecialUpload.php) returns a valid character entity ' ' if there is no warning. So the Javascript should test against that.
Comment 3 Brion Vibber 2008-03-20 21:48:39 UTC 
r32258
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links