Last modified: 2008-03-20 21:48:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13448 - Upload form w/o wpDestFileWarningAck generates error in upload.js
Upload form w/o wpDestFileWarningAck generates error in upload.js
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2008-03-20 10:12 UTC by Lupo
Modified: 2008-03-20 21:48 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Lupo 2008-03-20 10:12:31 UTC
The recent changes in SpecialUpload.php in revision 32077 have made the wpDestFileWarningAck hidden input disappear. I don't know if that isn't needed anymore, but in any case this generates a Javascript error in /skins-1.5/common/upload.js, line 102.

And while we're at it, line 99 of upload.js is missing a ';'. Instead of

if ( warning == '' || warning == '&nbsp' ) {

it should read

if ( warning == '' || warning == ' ' ) {
Comment 1 Raimond Spekking 2008-03-20 10:47:40 UTC
ID readded with r32217.

I leave this bug open because I am unsure if '&nbsp' is an typo or intent.
Comment 2 Lupo 2008-03-20 11:15:42 UTC
It's an error. The server (see function ajaxGetExistsWarning in SpecialUpload.php) returns a valid character entity ' ' if there is no warning. So the Javascript should test against that.
Comment 3 Brion Vibber 2008-03-20 21:48:39 UTC

Note You need to log in before you can comment on or make changes to this bug.