Last modified: 2008-09-03 02:29:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14089, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 12089 - Change $wgProxyKey to $wgSecretKey
Change $wgProxyKey to $wgSecretKey
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.12.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-11-24 16:32 UTC by Alexandre Emsenhuber [IAlex]
Modified: 2008-09-03 02:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
proposed patch (5.44 KB, patch)
2007-11-24 16:33 UTC, Alexandre Emsenhuber [IAlex] 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Alexandre Emsenhuber [IAlex] 2007-11-24 16:32:23 UTC 
As mentionned in DefaultSettings.php (and http://www.mediawiki.org/wiki/Manual:$wgProxyKey), $wgProxyKey should be deprecated and replaced by $wgSecretKey. However, this variable is actually used and put in LocalSettings.php by the installation script. For backward compatibility, Setup.php will check (with my patch) for $wgProxyKey if $wgSecretKey isn't set. 

I did also some cleanup in the function that create LocalSettings.php in config/index.php to put the generated comments at a better place.
Comment 1 Alexandre Emsenhuber [IAlex] 2007-11-24 16:33:24 UTC 
Created attachment 4372 [details]
proposed patch
Comment 2 Chad H. 2008-09-02 15:17:00 UTC 
Fixed in r40323.
Comment 3 Tim Starling 2008-09-03 02:29:20 UTC 
Reverted, pointless, breaks things.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links