Last modified: 2008-09-03 02:29:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12089 - Change $wgProxyKey to $wgSecretKey
Change $wgProxyKey to $wgSecretKey
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2007-11-24 16:32 UTC by Alexandre Emsenhuber [IAlex]
Modified: 2008-09-03 02:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

proposed patch (5.44 KB, patch)
2007-11-24 16:33 UTC, Alexandre Emsenhuber [IAlex]

Description Alexandre Emsenhuber [IAlex] 2007-11-24 16:32:23 UTC
As mentionned in DefaultSettings.php (and$wgProxyKey), $wgProxyKey should be deprecated and replaced by $wgSecretKey. However, this variable is actually used and put in LocalSettings.php by the installation script. For backward compatibility, Setup.php will check (with my patch) for $wgProxyKey if $wgSecretKey isn't set. 

I did also some cleanup in the function that create LocalSettings.php in config/index.php to put the generated comments at a better place.
Comment 1 Alexandre Emsenhuber [IAlex] 2007-11-24 16:33:24 UTC
Created attachment 4372 [details]
proposed patch
Comment 2 Chad H. 2008-09-02 15:17:00 UTC
Fixed in r40323.
Comment 3 Tim Starling 2008-09-03 02:29:20 UTC
Reverted, pointless, breaks things.

Note You need to log in before you can comment on or make changes to this bug.