Last modified: 2007-07-10 11:15:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10413 - DISPLAYTITLE doesn't unescape HTML entities
DISPLAYTITLE doesn't unescape HTML entities
Status: VERIFIED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.11.x
All All
: Normal minor (vote)
: ---
Assigned To: Aryeh Gregor (not reading bugmail, please e-mail directly)
http://test.wikipedia.org/wiki/I%27m_...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-30 14:31 UTC by Jelte (WebBoy)
Modified: 2007-07-10 11:15 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to fix this bug (537 bytes, patch)
2007-06-30 14:31 UTC, Jelte (WebBoy)
Details

Description Jelte (WebBoy) 2007-06-30 14:31:47 UTC
Created attachment 3855 [details]
Patch to fix this bug

DISPLAYTITLE shows literal character entities, instead of the characters.

DISPLAYTITLE should decode character entities because the skin converts special characters (like & in ') to HTML entities ( with htmlspecialchar() ).

This bug breaks {{DISPLAYTITLE:{{LCFIRST:{{PAGENAME}}}}}} on pages like [[I'm lovin' it]].
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-07-01 02:42:36 UTC
It works fine with {{DISPLAYTITLE:i'm lovin' it}}.  It's only when you use {{LCFIRST:{{PAGENAME}} }} that it appears to screw up.
Comment 2 Jelte (WebBoy) 2007-07-01 07:34:31 UTC
(In reply to comment #1)
> It works fine with {{DISPLAYTITLE:i'm lovin' it}}.

i'm lovin' it in normal text shows as i'm lovin' it. Why shouldn't {{DISPLAYTITLE:i'm lovin' it}} show as i'm lovin' it?

> It's only when you use
> {{LCFIRST:{{PAGENAME}} }} that it appears to screw up.

That's because {{PAGENAME}} uses wfEscapeWikiText(). 
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-07-09 19:07:31 UTC
Ah, I see your point.  Of course, HTML entities should be treated as canonically equivalent to actual characters by DISPLAYTITLE and its ilk.  And somehow I didn't notice that patch . . . not getting a lot of sleep lately.  I'll have to test it, then I'd be happy to commit it.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-07-10 01:32:51 UTC
Thanks, fixed in r23932
Comment 5 Jelte (WebBoy) 2007-07-10 11:15:31 UTC
Thank you

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links