Last modified: 2007-07-10 11:15:31 UTC
Created attachment 3855 [details] Patch to fix this bug DISPLAYTITLE shows literal character entities, instead of the characters. DISPLAYTITLE should decode character entities because the skin converts special characters (like & in ') to HTML entities ( with htmlspecialchar() ). This bug breaks {{DISPLAYTITLE:{{LCFIRST:{{PAGENAME}}}}}} on pages like [[I'm lovin' it]].
It works fine with {{DISPLAYTITLE:i'm lovin' it}}. It's only when you use {{LCFIRST:{{PAGENAME}} }} that it appears to screw up.
(In reply to comment #1) > It works fine with {{DISPLAYTITLE:i'm lovin' it}}. i'm lovin' it in normal text shows as i'm lovin' it. Why shouldn't {{DISPLAYTITLE:i'm lovin' it}} show as i'm lovin' it? > It's only when you use > {{LCFIRST:{{PAGENAME}} }} that it appears to screw up. That's because {{PAGENAME}} uses wfEscapeWikiText().
Ah, I see your point. Of course, HTML entities should be treated as canonically equivalent to actual characters by DISPLAYTITLE and its ilk. And somehow I didn't notice that patch . . . not getting a lot of sleep lately. I'll have to test it, then I'd be happy to commit it.
Thanks, fixed in r23932
Thank you
