Last modified: 2014-02-19 03:21:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10317 - Remove includes/templates/Userlogin.php, use HTMLForm class or Xml methods in includes/SpecialUserlogin.php instead
Remove includes/templates/Userlogin.php, use HTMLForm class or Xml methods in...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.10.x
All All
: Low enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2007-06-20 01:26 UTC by Nick Jenkins
Modified: 2014-02-19 03:21 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nick Jenkins 2007-06-20 01:26:51 UTC
Should includes/templates/Userlogin.php be merged into the includes/SpecialUserlogin.php page, using the Xml.php methods to draw user-input fields, instead of the templating system, as per most of the other Special pages?

For example, there is some overlap of form information between includes/SpecialPreferences.php's "User Profile" tab, and the login pages. However SpecialPreferences.php uses a single non-template file, and mostly outputs form fields using the Xml methods rather than outputting HTML directly, and overall seems nicer to work with because of it.
Comment 1 Alex Monk 2013-03-10 01:47:29 UTC
Looks like Gerrit change #27022 is related to this
Comment 2 spage 2013-03-20 05:54:36 UTC
The in-progress redesign of login/create account to use stacked labels and right-aligned help links[1] makes this more complicated. Even if we changed from undecorated list items to plain divs, HTMLForm and Xml would need changes to output the new CSS and layout.

[1] https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Login#Proposed
Comment 3 Tyler Romeo 2013-03-20 06:40:10 UTC
(In reply to comment #2)
> The in-progress redesign of login/create account to use stacked labels and
> right-aligned help links[1] makes this more complicated. Even if we changed
> from undecorated list items to plain divs, HTMLForm and Xml would need
> changes
> to output the new CSS and layout.
> 
> [1] https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Login#Proposed

Indeed, and I suggest that whatever team is doing the login page redesign look into what changes would need to be made, because it would be nonsensical to redesign the login page *before* resolving this issue. Otherwise we're just driving ourselves into a deeper hole.
Comment 4 Matthew Flaschen 2013-03-20 18:57:29 UTC
This bug doesn't actually suggest to use HTMLForm (though I know that's the idea of https://gerrit.wikimedia.org/r/#/c/27022/).
Comment 5 Tyler Romeo 2013-03-20 21:06:46 UTC
(In reply to comment #4)
> This bug doesn't actually suggest to use HTMLForm (though I know that's the
> idea of https://gerrit.wikimedia.org/r/#/c/27022/).

Indeed. My change just uses HTMLForm because it is the ideal case.
Comment 6 Gerrit Notification Bot 2013-08-22 18:17:58 UTC
Change 27022 abandoned by Parent5446:
Re-implemented Special:Userlogin using FormSpecialPage.

Reason:
The rest of the login system needs to be fixed before the UI part.

https://gerrit.wikimedia.org/r/27022
Comment 7 Kunal Mehta (Legoktm) 2014-02-17 21:18:09 UTC
Assuming Tyler isn't planning to continue working on this.
Comment 8 Matthew Flaschen 2014-02-19 03:18:13 UTC
The discussion of https://www.mediawiki.org/wiki/Requests_for_comment/HTML_templating_library (including the in-person part at the summit, reflected at https://www.mediawiki.org/wiki/Architecture_Summit_2014/HTML_templating ) is relevant here.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links