Last modified: 2007-06-29 13:50:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11951, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 9951 - Enable [[MediaWiki:GeSHi.css]]
Enable [[MediaWiki:GeSHi.css]]
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
All All
: Normal minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2007-05-18 08:59 UTC by Daniel Cannon (AmiDaniel)
Modified: 2007-06-29 13:50 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Daniel Cannon (AmiDaniel) 2007-05-18 08:59:21 UTC
With the addition of the new <source> tags, many objections have been raised about the angry fruit-salad often generated by them. This angry fruit-salad can be fixed in Common.css quite easily; however, due to the order of loading the stylesheets it requires the use of !important and clogs up the css pages making them unreadable. See for example this fix:

What I'd like to suggest is that a [[MediaWiki:GeSHi.css]] page be added that will take priority over the stylesheets loaded by the syntax hilighting, such that the colors used by them can be easily fixed and customized on a per-wiki basis. Should be a relatively simple implementation.
Comment 1 Phil Boswell 2007-05-18 09:08:50 UTC
Is there some hook whereby an extension can insert a CSS stylesheet into the processing chain? It would seem that a generic solution rather than a particular hack would be a better solution.

Oh, and should this bug be under "MediaWiki>Page Rendering" or some sub-category of "MediaWiki extensions" ?
Comment 2 Brion Vibber 2007-05-18 15:40:19 UTC
Assuming it's using a style sheet, it'll use the same mechanism it already does, which is the thingy to add a header thingy.
Comment 3 Antoine "hashar" Musso (WMF) 2007-05-18 21:29:18 UTC
Committed as r22246
Comment 4 Brion Vibber 2007-05-21 19:47:13 UTC
I've changed it from 'GeSHi.css' to 'geshi.css'. This is more consistent with other behavior, and fixes the Special:Allmessages bug. r22308.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-07 23:22:31 UTC
Uh, I know I should've commented earlier, but shouldn't the solution to this have been to load extension stylesheets *before* site-specific customization stylesheets?  This seems like . . . a bad idea, to have separate custom stylesheets loaded for every single extension that wants them.
Comment 6 Rob Church 2007-06-29 05:11:55 UTC
Updating summary to reflect the current issue; this is also a minor bug, since it prevents overriding the style effectively.
Comment 7 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-29 05:24:37 UTC
No, that's bug 10184.  I reopened to propose we undo this specific feature, I guess, more than proposing a separate thing.  But whatever.  :D
Comment 8 Brion Vibber 2007-06-29 13:50:41 UTC
The advantage of a separate entry is that it doesn't have to be loaded when you're *not* on a page using the extension.

Note You need to log in before you can comment on or make changes to this bug.