Last modified: 2010-05-15 15:48:20 UTC
If $wgRepositoryBaseUrl contains a '?' then when the description of Example.jpg is fetched, the page requested contains two '?'s: http://commons.examplewiki.org/index.php?title=Image:Example.jpg?action=render This causes the page for "Image:Example.jpg?action=render" to be displayed so there are two logos, toolboxes and so on, and the description includes "No file by this name exists, you can upload it." I've written a small patch for ImagePage.php that fixes this: 363c363,369 < $text = Http::get($url . '?action=render'); --- > if(strrpos($url,'?')===false) > $delimiter = '?'; > else > $delimiter = '&'; > > $text = Http::get($url . $delimiter. 'action=render'); > I hope this is helpful!
Created attachment 3390 [details] Fixes described issue. The indentation was affected when I pasted this into the description field.
Fixed in r20696. Since the same type of check is used in a place in Title.php, I extracted it to a common function wfAppendQuery() and use it in both places.