Last modified: 2008-02-27 03:50:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11156, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 9156 - Invalid heading markup made valid by template expansion, causes ghost section


Summary:	Invalid heading markup made valid by template expansion, causes ghost section

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Page editing (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://en.wikipedia.org/wiki/User:Mohrr
Whiteboard:
Keywords:	patch, patch-need-review

Duplicates:	9815 (view as bug list)
Depends on:	12652
Blocks:	4899
	Show dependency tree / graph

Reported:	2007-03-03 01:42 UTC by Robert Mohr
Modified:	2008-02-27 03:50 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Proposed patch (580 bytes, patch) 2007-03-04 01:31 UTC, Aryeh Gregor (not reading bugmail, please e-mail directly)	Details
Add an attachment (proposed patch, testcase, etc.)

Description Robert Mohr 2007-03-03 01:42:58 UTC

If you create a heading as such:

==Section 1=={{template}}

and then have 

==Section 2==

Clicking the "edit" link for "Section 1" brings up an editor for "Section 2",
not "Section 1".

I found this on an article and removed fixed the offending formatting, but
recreated it on my user page:

http://en.wikipedia.org/wiki/User:Mohrr

Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-03-04 01:31:32 UTC

Created attachment 3287 [details]
Proposed patch

The problem is in Parser::extractSections, pretty much as expected: the regex
doesn't like non-whitespace on the same line as a wikitext header.  Patch
probably fixes it, but I haven't tested it, since PHP broke when I tried to
install 5.2 locally and I haven't had time to fix it.

Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-05-07 00:47:55 UTC

*** Bug 9815 has been marked as a duplicate of this bug. ***

Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-05-07 01:06:11 UTC

Fixed in r21950.

Comment 4 Brion Vibber 2007-05-08 15:12:22 UTC

Reverted r21950

Comment 5 Brion Vibber 2007-05-08 15:13:39 UTC

There is indeed not supposed to be anything else on the same line as a heading.
The bug is that some constructions end up internally stripping that data from
the line so it ends up getting incorrectly processed for display as though it
were valid input.

Comment 6 Tim Starling 2007-11-13 10:24:43 UTC

Changed bug title. Similar to bug 11911.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links