Last modified: 2006-11-20 05:16:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T9918, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 7918 - update "Pages transcluded onto ... this page:" on edit preview
update "Pages transcluded onto ... this page:" on edit preview
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.9.x
All All
: Normal enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-11-14 13:31 UTC by ChemicalBit
Modified: 2006-11-20 05:16 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
implements the request (2.22 KB, patch)
2006-11-14 13:43 UTC, Fyren
Details
fixes and section handling as suggested (3.94 KB, patch)
2006-11-18 01:02 UTC, Fyren
Details

Description ChemicalBit 2006-11-14 13:31:27 UTC
When you edit a page, and you add a template ( or other transclusion ) and you
press "show preview" , you can see a preview that have aslo the (new added)
template.

But the template list just below edit textarea ("Pages transcluded onto the
current version of this page:" in english interface) is not updated, until you
save the page.

(the precise statement "the current version" is in english interface. Other
interface, italian one for example, have not. So it's less clear what that list
_exactly_ is )



I suggest to improve to show the list updated when the user press "show preview".
It is: the list should be pertinent to the version shown in the preview.


This may be usefull :

1) to check the exactness of the template name in the page (if one mispelled a
template name, it will be shown in red colour in the list), as in complex page
one may not relize it

2) to find out if a template do not exist yet, or if have been deleted

3) to find out which template is used in a page "I want to use it in the page
I'm writing too"

4)to click on the link and open in another windows / tab the template page to
look at instruction, for complex syntax templates

and maybe more
Comment 1 Fyren 2006-11-14 13:43:16 UTC
Created attachment 2708 [details]
implements the request

Seems to work fine on my test wiki.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-11-17 03:16:38 UTC
Patch applied in r17738.
Comment 3 Raimond Spekking 2006-11-17 17:38:59 UTC
(In reply to comment #2)
> Patch applied in r17738.

[[Special:Version]]: MediaWiki: 1.9alpha (r17763)

Sorry, but don't work for me, neither on dewiki nor in dews.

The new message is in [[Special:Allmessages]] but after clicking on "Preview"
there is no list. At the HTML sourcecode I can see

<div class="templatesUsed">

</div>

only... empty. zero. nada :-(
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-11-17 20:56:17 UTC
It works correctly for me on enwiki.  Does it fail for anyone else?  Are you
using any custom scripts?  I didn't see the edit summary preview change until I
stopped using a live preview script.

(I did notice an unintended feature: when previewing a section, it will now only
show templates used in that *section*.  This seems like a good thing to me,
overall, but this should also happen when editing and not previewing a section,
and the message should be clarified accordingly.  Also, it doesn't make a lot of
sense for "show changes" to still use the template list for the current version
of the page.  I don't have time right now, but I'll fix those tomorrow night if
no one else does before me.)
Comment 5 Raimond Spekking 2006-11-17 21:10:06 UTC
(In reply to comment #4)
> It works correctly for me on enwiki.  Does it fail for anyone else?  Are you
> using any custom scripts?  I didn't see the edit summary preview change until I
> stopped using a live preview script.

No custom scipt at de-wikisource where the problem exists too. But I have found
that if the preference "Show preview before edit box" is OFF the preview of used
templates fails.

If the option is ON it works well.
Comment 6 Raimond Spekking 2006-11-17 21:44:13 UTC
And please check whu(In reply to comment #5)

> If the option is ON it works well.

And [[MediaWiki:templatesused]] is still used instead of
[[MediaWiki:templatesusedpreview]]
Comment 7 Fyren 2006-11-18 01:02:38 UTC
Created attachment 2724 [details]
fixes and section handling as suggested

This patch fixes the problem with the preview being after the edit box (my
problem, I depended on the preview being parsed before displaying the used
templates) and the message problem (Simetrical's problem, he broke it when he
moved formatTemplates into Linker.php).

It also checks to see if you're editing a section to display the appropriate
message and only the templates for that section.
Comment 8 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-11-20 05:16:21 UTC
Patch applied with trivial modifications in r17800.  If there are any further
problems, please open a new bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links