Last modified: 2006-10-11 06:23:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T9351, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 7351 - Typo added to Parser.php in r16052
Typo added to Parser.php in r16052
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2006-09-17 01:25 UTC by Aryeh Gregor (not reading bugmail, please e-mail directly)
Modified: 2006-10-11 06:23 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-09-17 01:25:31 UTC
In r16052, when Tim was adding the OT_PREPROCESS output type, he changed 

-                 if ( $this->mOutputType == OT_HTML || $this->mOutputType ==
+                 if ( !$this->mOutputType != OT_MSG ) {

That should, of course, be

+                 if ( $this->mOutputType != OT_MSG ) {

with no ! before $this->mOutputType, an integer variable.  The bug is on line
2719, and I'm not sure what actual effect it has, since I haven't looked too
closely at this bit of code (variable substitution).
Comment 1 Tim Starling 2006-10-11 06:23:54 UTC
Fixed by brion in r16549

Note You need to log in before you can comment on or make changes to this bug.