Last modified: 2014-11-19 23:05:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75379, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 73379 - VisualEditor: Table column adding icon must be flipped for RTL
VisualEditor: Table column adding icon must be flipped for RTL
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-11-19 (1.25wmf9)
Assigned To: Ed Sanders
:
Depends on:
Blocks: ve-rtl ve-tablesupport
  Show dependency tree / graph
 
Reported: 2014-11-13 19:03 UTC by Amir E. Aharoni
Modified: 2014-11-19 23:05 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
rtl table with the fix (45.26 KB, image/png)
2014-11-15 01:40 UTC, etonkovidova 		Details
column row arrows - proposed correction? (16.86 KB, image/png)
2014-11-15 01:41 UTC, etonkovidova 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Amir E. Aharoni 2014-11-13 19:03:58 UTC 
The icons for adding columns in RTL must be flipped.
Comment 1 Gerrit Notification Bot 2014-11-14 17:17:33 UTC 
Change 173310 had a related patch set uploaded by Esanders:
Make table inserts directional

https://gerrit.wikimedia.org/r/173310
Comment 2 Gerrit Notification Bot 2014-11-14 22:32:31 UTC 
Change 173310 merged by jenkins-bot:
Make table inserts directional

https://gerrit.wikimedia.org/r/173310
Comment 3 etonkovidova 2014-11-15 01:39:25 UTC 
Just to confirm - for left-to-right we have: 
<div class="ve-ce-tableNodeOverlay" style="top: 20.5833px; left: 25px;”>

and inserted table displays two arrows on the left. 

For rtl(with the fix), we have: 
<div class="ve-ce-tableNodeOverlay" style="top: 20.5833px; left: 754.267px;”> which makes the row arrow to appear at the left side  and the column arrows appear on the right side - see the attached screenshot. 


Shouldn't it be something like 
<div class="ve-ce-tableNodeOverlay" style="top: 20.5833px; right: 25px;”> ? -see the attached screenshot
Comment 4 etonkovidova 2014-11-15 01:40:09 UTC 
Created attachment 17137 [details]
rtl table with the fix
Comment 5 etonkovidova 2014-11-15 01:41:36 UTC 
Created attachment 17138 [details]
column row arrows - proposed correction?
Comment 6 etonkovidova 2014-11-19 23:05:57 UTC 
The fix is in betalabs.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links