Last modified: 2010-05-15 15:28:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T2733, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 733 - config/index.php does not detect full disk (fwrite result not checked)
config/index.php does not detect full disk (fwrite result not checked)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.3.x
All All
: Low normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
http://www.php.net/manual/en/function...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2004-10-17 08:47 UTC by Zigger
Modified: 2010-05-15 15:28 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Zigger 2004-10-17 08:47:09 UTC 
config/index.php does not detect a full disk, as the fwrite() result is not checked.
Comment 1 Brion Vibber 2004-10-17 08:58:00 UTC 
If you have a full disk, a lot more than this will probably fail...
Comment 2 Zigger 2004-10-17 14:38:49 UTC 
I agree with Brion's comment, which is one of the reasons I marked this as low
priority.  But:

1. this is "probably" the only direct write to the mediawiki folder/directory
tree.  Databases and image uploads and /tmp could well be on separate
file-systems (and have related writes that could use error-checking).

2. it is better to detect and report a full/restricted file-system early and
descriptively.  Config is an early and descriptive process.
Comment 3 Antoine "hashar" Musso (WMF) 2004-11-13 19:42:21 UTC 
Probably fixed in cvs. Dieing if fwrite() return false.
Comment 4 Zigger 2004-12-16 22:53:09 UTC 
The fix was first released with v1.4beta1.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links