Last modified: 2014-11-12 23:23:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74802, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72802 - VisualEditor: Regular context menu trying to render on TableSelections
VisualEditor: Regular context menu trying to render on TableSelections
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-11-05 (1.25wmf7)
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks: ve-tablesupport
  Show dependency treegraph
 
Reported: 2014-10-31 05:27 UTC by Rummana Yasmeen
Modified: 2014-11-12 23:23 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (19.33 KB, image/png)
2014-10-31 05:27 UTC, Rummana Yasmeen
Details
video capture (2.17 MB, video/quicktime)
2014-11-03 20:33 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-10-31 05:27:57 UTC
Created attachment 16972 [details]
Screenshot

Steps to reproduce:

1.Insert a table
2.Add a link inside a content cell
3.Click on the link in Edit mode

Observed Result:
It scrolls the page down and shows the context menu of link inspector at the bottom left corner of CE

See the screenshot attached
Comment 1 Rummana Yasmeen 2014-10-31 05:29:29 UTC
In fact, after that point on, clicking on any cell scrolls the page to the bottom.
Comment 2 Ed Sanders 2014-11-03 15:28:20 UTC
I couldn't get any strange behaviour when adding/editing links inside the cell. The only odd behaviour was when I tried to open the link inspector on a table selection using the keyboard shortcut (while the button is still greyed out). Being able to do that is a separate issue which I have fixed with
https://gerrit.wikimedia.org/r/#/q/topic:command-selection,n,z
Comment 3 Rummana Yasmeen 2014-11-03 20:33:48 UTC
Created attachment 17005 [details]
video capture

Hmm..I was actually pointing to the issue of scrolling to the end of page once you click on the link or any other cell after adding a link as you can see from this video capture
Comment 4 Ed Sanders 2014-11-04 09:56:33 UTC
Found the problem here. If the cell contains *only* a link then getAvailableTools says the whole cell is annotated and so tries to render the link inspector.
Comment 5 Gerrit Notification Bot 2014-11-04 10:10:15 UTC
Change 170896 had a related patch set uploaded by Esanders:
Disable desktop context on table selections

https://gerrit.wikimedia.org/r/170896
Comment 6 Gerrit Notification Bot 2014-11-04 18:00:49 UTC
Change 170896 merged by jenkins-bot:
Disable desktop context on table selections

https://gerrit.wikimedia.org/r/170896
Comment 7 Rummana Yasmeen 2014-11-05 00:20:55 UTC
Verified the fix in Betalabs
Comment 8 Rummana Yasmeen 2014-11-05 22:52:45 UTC
Verified the fix in test2
Comment 9 Rummana Yasmeen 2014-11-12 23:23:17 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links