Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73323, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 71323 - CentralAuthUser::matchHash should only match the hash, not also update the password

Summary:	CentralAuthUser::matchHash should only match the hash, not also update the pa...

Status: RESOLVED FIXED Product: MediaWiki extensions Classification: Unclassified Component: CentralAuth (Other open bugs) Version: unspecified Hardware: All All Importance: High normal (vote) Target Milestone: --- Assigned To: Kunal Mehta (Legoktm) URL: Whiteboard: Keywords: Depends on: Blocks: code_quality   Show dependency tree / graph		Reported: 2014-09-25 19:03 UTC by Kunal Mehta (Legoktm) Modified: 2014-10-21 19:02 UTC (History) CC List: 7 users (show) agarrett hoo legoktm.wikipedia ori tylerromeo vasilvv wikimedia.bugs See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2014-09-25 19:03:40 UTC CentralAuthUser::authenticate() should take care of updating. hotfix is I7a22fa5825e2831d4c43f85094121ec56e7cf290, see Ori's CR there. Comment 1 Gerrit Notification Bot 2014-10-21 18:45:11 UTC Change 167859 had a related patch set uploaded by Legoktm: Move password update logic out of CentralAuthUser::matchHash() https://gerrit.wikimedia.org/r/167859 Comment 2 Gerrit Notification Bot 2014-10-21 19:01:59 UTC Change 167859 merged by jenkins-bot: Move password update logic out of CentralAuthUser::matchHash() https://gerrit.wikimedia.org/r/167859