Last modified: 2014-11-12 15:12:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72835, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70835 - Remove assumption from MediaWiki core that JS/CSS are only in MediaWiki namespace or User subpages
Remove assumption from MediaWiki core that JS/CSS are only in MediaWiki names...
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: gadgets-2.0
  Show dependency tree / graph
 
Reported: 2014-09-15 03:50 UTC by Kunal Mehta (Legoktm)
Modified: 2014-11-12 15:12 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2014-09-15 03:50:49 UTC 
There are a few places in MediaWiki that assume that JS/CSS are only stored in the MediaWiki namespace or in User subpages; basically anything that calls Title::isCssOrJsPage() or isCssJsSubpage().

This isn't a very good assumption, and with the introduction of Gadgets 2.0 and the Gadgets namespace, this will be false.
Comment 1 Kunal Mehta (Legoktm) 2014-09-15 03:51:31 UTC 
An example of such an assumption is I64e86c74173b1c88cac71483327cacdd8b9967b9.
Comment 2 Kunal Mehta (Legoktm) 2014-09-15 04:53:50 UTC 
(In reply to Kunal Mehta (Legoktm) from comment #0)
> basically anything that
> calls Title::isCssOrJsPage() or isCssJsSubpage().

A lot of these calls seem to be for supporting the deprecated ShowRawCssJs hook. Except that hook was only deprecated in 1.24, so we'll need to wait until 1.25 to kill it :/
Comment 3 Gerrit Notification Bot 2014-09-15 05:03:31 UTC 
Change 160392 had a related patch set uploaded by Legoktm:
ResourceLoaderWikiModule: Only check content format instead of namespace

https://gerrit.wikimedia.org/r/160392
Comment 4 Helder 2014-09-15 15:47:53 UTC 
Will this have any impact on things like the visibility of the toolbars (the classic and/or from WikiEditor)? See e.g.:
* Bug 29908
* Bug 30795
* Bug 69447
Comment 5 Gerrit Notification Bot 2014-09-23 21:38:16 UTC 
Change 160392 merged by jenkins-bot:
ResourceLoaderWikiModule: Only check content format instead of namespace

https://gerrit.wikimedia.org/r/160392
Comment 6 Andre Klapper 2014-11-12 15:12:15 UTC 
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links