Last modified: 2014-09-15 15:22:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 70827 - [1.24wmf20] Fatal error: Call to a member function getProperty() on a non-object, after completely history merging a page
[1.24wmf20] Fatal error: Call to a member function getProperty() on a non-obj...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GeoCrumbs (Other open bugs)
master
All All
: High critical (vote)
: ---
Assigned To: Florian
https://zh.wikivoyage.org/wiki/%E6%A8...
:
Depends on:
Blocks: wmf-deployment
  Show dependency tree / graph
 
Reported: 2014-09-14 14:28 UTC by zhuyifei1999
Modified: 2014-09-15 15:22 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description zhuyifei1999 2014-09-14 14:28:17 UTC 
1. Module:Sandbox history splitted through delete & undelete.
2. Merged full history of Module:Sandbox to Module:Pagebanner through Special:Mergehistory.
3. Module:Sandbox fail. Full undeletion doesn't help.
Comment 1 Jesús Martínez Novo (Ciencia Al Poder) 2014-09-14 14:44:21 UTC 
The error message is:

PHP fatal error in /srv/mediawiki/php-1.24wmf20/extensions/GeoCrumbs/GeoCrumbs.class.php line 126:
Call to a member function getProperty() on a non-object 

getParserCache() can return null, but the code doesn't handle this situation, assuming it will never return null.
Comment 2 Gerrit Notification Bot 2014-09-14 21:58:15 UTC 
Change 160306 had a related patch set uploaded by Florianschmidtwelzow:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160306
Comment 3 Gerrit Notification Bot 2014-09-14 23:17:33 UTC 
Change 160306 merged by jenkins-bot:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160306
Comment 4 Gerrit Notification Bot 2014-09-15 04:13:47 UTC 
Change 160388 had a related patch set uploaded by Florianschmidtwelzow:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160388
Comment 5 Gerrit Notification Bot 2014-09-15 04:28:31 UTC 
Change 160389 had a related patch set uploaded by Florianschmidtwelzow:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160389
Comment 6 Gerrit Notification Bot 2014-09-15 14:21:20 UTC 
Change 160389 merged by jenkins-bot:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160389
Comment 7 Gerrit Notification Bot 2014-09-15 14:21:30 UTC 
Change 160388 merged by jenkins-bot:
Handle return value NULL of GeoCrumbs::getParserCache

https://gerrit.wikimedia.org/r/160388
Comment 8 Andre Klapper 2014-09-15 15:10:13 UTC 
Patches merged to 1.24wmf21, 1.24wmf20 and master. Thanks! Closing as FIXED.
Comment 9 Florian 2014-09-15 15:22:42 UTC 
And deployed to wikivoyage :)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links