Last modified: 2014-09-16 22:36:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72615, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70615 - Fix extensions depending on skins/common/
Fix extensions depending on skins/common/
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.24rc
All All
: High normal (vote)
: ---
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks: 69277
  Show dependency tree / graph
 
Reported: 2014-09-09 17:08 UTC by Bartosz Dziewoński
Modified: 2014-09-16 22:36 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2014-09-09 17:08:09 UTC 
We need to fix extensions depending on skins/common/ before we kill it. There's a bunch that all require small changes, so I'm not going to file a separate bug for every one.
Comment 1 Bartosz Dziewoński 2014-09-09 17:20:00 UTC 
This is the list of thing I intend to fix or at least carefully look at.

The search returned a lot more results, mostly false positives. I also excluded commented-out code, backwards-compatibility for MW pre 1.17, and things that were clearly broken for a long time already.


Searching 11631 files for "/common[^s]" (regex, case sensitive)

extensions\CleanChanges\CleanChanges_body.php:
  531  		global $wgStylePath;
  532  		$image = Xml::element( 'img', array(
  533: 			'src' => $wgStylePath . '/common/images/magnify-clip.png',
  534  			'alt' => $this->msg( 'cleanchanges-showuserlinks' )->text(),
  535  			'title' => $this->msg( 'cleanchanges-showuserlinks' )->text(),

extensions\EducationProgram\includes\pagers\EPPager.php:
  593  					}
  594  
  595: 					$image = htmlspecialchars( "$wgStylePath/common/images/$image" );
  596  					$link = $this->makeLink(
  597  								"<img width=\"12\" height=\"12\" alt=\"$alt\" src=\"$image\" />" .

extensions\IndexFunction\SpecialIndex.php:
   66  		global $wgStylePath;
   67  
   68: 		$encUrl = htmlspecialchars( $wgStylePath . '/common/images/Arr_' . $dir . '.png' );
   69  		$encAlt = htmlspecialchars( $alt );
   70  		$encTitle = htmlspecialchars( $title );

extensions\InterwikiIntegration\InterwikiIntegrationChangesList.php:
  604  		$this->lastdate = '';
  605  		$this->rclistOpen = false;
  606: 		$script = Html::linkedScript( $wgStylePath . "/common/enhancedchanges.js?$wgStyleVersion" );
  607  		return $script;
  608  	}
  ...
 1031  	protected function arrow( $dir, $alt='', $title='' ) {
 1032  		global $wgStylePath;
 1033: 		$encUrl = htmlspecialchars( $wgStylePath . '/common/images/Arr_' . $dir . '.png' );
 1034  		$encAlt = htmlspecialchars( $alt );
 1035  		$encTitle = htmlspecialchars( $title );

extensions\MultiUpload\SpecialMultiUpload.php:
  135  			"<style>#mw-upload-form > :first-child { display:none; }\n"
  136  			. ".client-js #mw-upload-form > * { display:none; }\n"
  137: 			. ".client-js #mw-upload-form { background-image:url($wgStylePath/common/images/spinner.gif); min-height:20px; min-width:20px; background-repeat:no-repeat; }\n"
  138  			. '</style>' );
  139  	}

extensions\PerPageLicense\PerPageLicense.php:
   52          'cc-0' => array(
   53                  'url' => 'http://creativecommons.org/publicdomain/zero/1.0/',
   54:                 'src' => "{$wgStylePath}/common/images/cc-by-sa.png",
   55                  'alt' => 'Creative Commons 0',
   56          ),
   57          'cc-by-nc-sa' => array(
   58                  'url' => 'http://creativecommons.org/licenses/by-nc/3.0/',
   59:                 'src' => "{$wgStylePath}/common/images/cc-by-nc-sa.png",
   60                  'alt' => 'Creative Commons Attribution-NonCommercial 3.0 Unported',
   61          ),
   62          'cc-by' => array(
   63                  'url' => 'http://creativecommons.org/licenses/by/3.0/',
   64:                 'src' => "{$wgStylePath}/common/images/cc-by.png",
   65                  'alt' => 'Creative Commons Attribution 3.0 Unported',
   66          ),
   67          'cc-by-sa' => array(
   68                  'url' => 'http://creativecommons.org/licenses/by-sa/3.0/',
   69:                 'src' => "{$wgStylePath}/common/images/cc-by-sa.png",
   70                  'alt' => 'Creative Commons Attribution Share-Alike 3.0 Unported',
   71          ),
   72          'gnu-fdl' => array(
   73                  'url' => 'http://www.gnu.org/copyleft/fdl.html',
   74:                 'src' => "{$wgStylePath}/common/images/gnu-fdl.png",
   75                  'alt' => 'GNU Free Documentation License',
   76          ),
   77          'public-domain' => array(
   78                  'url' => 'http://creativecommons.org/licenses/publicdomain/',
   79:                 'src' => "{$wgStylePath}/common/images/public-domain.png",
   80                  'alt' => 'public domain'
   81          ),

extensions\SecurePoll\includes\pages\ListPage.php:
   44  			$msgReason = wfMsgHtml( 'securepoll-strike-reason' );
   45  			$encAction = htmlspecialchars( $this->getTitle()->getLocalUrl() );
   46: 			$encSpinner = htmlspecialchars( "$wgStylePath/common/images/spinner.gif" );
   47  			$script = Skin::makeVariablesScript( array(
   48  				'securepoll_strike_button' => wfMsg( 'securepoll-strike-button' ),

extensions\SemanticPageMaker\includes\models\SPM_OM_ParserFunction.php:
   26  				$jsm = SMWResourceManager::SINGLETON();
   27  				if ( $wgUseAjax ) {
   28: 					$jsm->addScriptIf( "{$wgStylePath}/common/ajax.js" );
   29  				}
   30  				$jsm->addScriptIf( $smwgHaloScriptPath .  '/scripts/prototype.js' );

extensions\SemanticPageMaker\specials\SPMQueryInterface\SPM_QueryInterface.php:
   29  			$jsm = SMWResourceManager::SINGLETON();
   30  			if ( $wgUseAjax ) {
   31: 				$jsm->addScriptIf( "{$wgStylePath}/common/ajax.js" );
   32  			}
   33  			$jsm->addScriptIf( $smwgHaloScriptPath .  '/scripts/prototype.js' );

extensions\SemanticPageMaker\specials\SPMQueryInterface\SPM_QueryInterface2.php:
   29  			$jsm = SMWResourceManager::SINGLETON();
   30  			if ( $wgUseAjax ) {
   31: 				$jsm->addScriptIf( "{$wgStylePath}/common/ajax.js" );
   32  			}
   33  			$jsm->addScriptIf( $smwgHaloScriptPath .  '/scripts/prototype.js' );

extensions\SemanticPageMaker\specials\WidgetAssembler\SPM_UploadWindow.php:
  841  wgAjaxLicensePreview = {$alp};
  842  </script>
  843: <script type=\"text/javascript\" src=\"{$wgStylePath}/common/upload.js?{$wgStyleVersion}\"></script>
  844  		" );
  845  

extensions\SemanticResultFormats\formats\Exhibit\SRF_Exhibit.php:
   54  
   55  		if ( defined( 'MW_SUPPORTS_RESOURCE_MODULES' ) ) {
   56: 			SMWOutputs::requireHeadItem( 'exhibit-compat', Html::linkedScript( "$wgScriptPath/common/wikibits.js" ) );
   57  		}
   58  		

extensions\TimedMediaHandler\TimedMediaTransformOutput.php:
   46  	function getUrl( $sizeOverride = false ){
   47  		global $wgStylePath;
   48: 		$url = "$wgStylePath/common/images/icons/fileicon-ogg.png";
   49  
   50  		if ( $this->isVideo ) {

extensions\WikiArticleFeeds\WikiArticleFeeds_body.php:
  139  
  140  		$result = '<li id="feedlinks">';
  141: 		$feedIcon = $wgServer . $wgStylePath . "/common/images/feed-icon.png";
  142  
  143  		# Test for feedBurner presence

extensions\Wikilog\WlFeed.body.php:
  434  		if ( !in_array( 'style', $this->mQuirks ) ) {
  435  			echo '<?xml-stylesheet type="text/css" href="' .
  436: 				htmlspecialchars( wfExpandUrl( "$wgStylePath/common/feed.css?$wgStyleVersion" ) ) .
  437  				'"?' . ">\n";
  438  		}
Comment 2 Gerrit Notification Bot 2014-09-09 17:38:58 UTC 
Change 159351 had a related patch set uploaded by Bartosz Dziewoński:
Provide own magnify-clip.png image

https://gerrit.wikimedia.org/r/159351
Comment 3 Bartosz Dziewoński 2014-09-09 17:44:10 UTC 
The ones in SemanticPageMaker seem to be dead code, or I can't figure the thing out. I'd file a bug, but it doesn't have a component. I'll let that be.
Comment 4 Gerrit Notification Bot 2014-09-09 17:50:11 UTC 
Change 159352 had a related patch set uploaded by Bartosz Dziewoński:
Fix reference to wikibits.js

https://gerrit.wikimedia.org/r/159352
Comment 5 Gerrit Notification Bot 2014-09-09 17:55:04 UTC 
Change 159353 had a related patch set uploaded by Bartosz Dziewoński:
Remove reference to feed.css

https://gerrit.wikimedia.org/r/159353
Comment 6 Gerrit Notification Bot 2014-09-09 17:55:46 UTC 
Change 159353 merged by jenkins-bot:
Remove reference to feed.css

https://gerrit.wikimedia.org/r/159353
Comment 7 Gerrit Notification Bot 2014-09-09 18:47:56 UTC 
Change 159361 had a related patch set uploaded by Bartosz Dziewoński:
Correct path to fileicon-ogg.png for MW 1.24

https://gerrit.wikimedia.org/r/159361
Comment 8 Bartosz Dziewoński 2014-09-09 18:50:11 UTC 
InterwikiIntegrationChangesList looks quite broken too. I'll let that be.
Comment 9 Gerrit Notification Bot 2014-09-09 18:50:12 UTC 
Change 159361 merged by jenkins-bot:
Correct path to fileicon-ogg.png for MW 1.24

https://gerrit.wikimedia.org/r/159361
Comment 10 Gerrit Notification Bot 2014-09-09 19:17:16 UTC 
Change 159368 had a related patch set uploaded by Bartosz Dziewoński:
Provide own arrow images

https://gerrit.wikimedia.org/r/159368
Comment 11 Gerrit Notification Bot 2014-09-09 19:21:14 UTC 
Change 159369 had a related patch set uploaded by Bartosz Dziewoński:
Provide own arrow images

https://gerrit.wikimedia.org/r/159369
Comment 12 Gerrit Notification Bot 2014-09-09 19:25:46 UTC 
Change 159368 merged by jenkins-bot:
Provide own arrow images

https://gerrit.wikimedia.org/r/159368
Comment 13 Gerrit Notification Bot 2014-09-09 19:26:02 UTC 
Change 159369 merged by jenkins-bot:
Provide own arrow images

https://gerrit.wikimedia.org/r/159369
Comment 14 Gerrit Notification Bot 2014-09-09 19:29:42 UTC 
Change 159370 had a related patch set uploaded by Bartosz Dziewoński:
Remove usage of spinner.gif

https://gerrit.wikimedia.org/r/159370
Comment 15 Gerrit Notification Bot 2014-09-09 19:32:48 UTC 
Change 159351 merged by jenkins-bot:
Provide own magnify-clip.png image

https://gerrit.wikimedia.org/r/159351
Comment 16 Gerrit Notification Bot 2014-09-09 19:39:49 UTC 
Change 159372 had a related patch set uploaded by Bartosz Dziewoński:
Update path to license footer icons for MW 1.24

https://gerrit.wikimedia.org/r/159372
Comment 17 Gerrit Notification Bot 2014-09-09 19:49:38 UTC 
Change 159373 had a related patch set uploaded by Bartosz Dziewoński:
Use .feedlink class rather than feed-icon.png file

https://gerrit.wikimedia.org/r/159373
Comment 18 Gerrit Notification Bot 2014-09-09 19:57:52 UTC 
Change 159376 had a related patch set uploaded by Bartosz Dziewoński:
Provide own spinner image

https://gerrit.wikimedia.org/r/159376
Comment 19 Bartosz Dziewoński 2014-09-09 20:02:51 UTC 
(This is all.)
Comment 20 Gerrit Notification Bot 2014-09-09 21:59:52 UTC 
Change 159376 merged by jenkins-bot:
Provide own spinner image

https://gerrit.wikimedia.org/r/159376
Comment 21 Bartosz Dziewoński 2014-09-13 15:52:25 UTC 
Four patches remain to be merged:
* https://gerrit.wikimedia.org/r/159352 (SemanticResultFormats)
* https://gerrit.wikimedia.org/r/159370 (SecurePoll)
* https://gerrit.wikimedia.org/r/159372 (PerPageLicense)
* https://gerrit.wikimedia.org/r/159373 (WikiArticleFeeds)
Comment 22 Gerrit Notification Bot 2014-09-13 16:25:50 UTC 
Change 159352 abandoned by Bartosz Dziewoński:
Fix reference to wikibits.js

Reason:
Per CR, this code is also severely broken and this isn't worth doing.

https://gerrit.wikimedia.org/r/159352
Comment 23 Gerrit Notification Bot 2014-09-14 12:14:10 UTC 
Change 159373 merged by jenkins-bot:
Use .feedlink class rather than feed-icon.png file

https://gerrit.wikimedia.org/r/159373
Comment 24 Gerrit Notification Bot 2014-09-16 16:33:12 UTC 
Change 159372 merged by jenkins-bot:
Update path to license footer icons for MW 1.24

https://gerrit.wikimedia.org/r/159372
Comment 25 Gerrit Notification Bot 2014-09-16 22:23:44 UTC 
Change 159370 merged by jenkins-bot:
Remove usage of spinner.gif

https://gerrit.wikimedia.org/r/159370
Comment 26 James Forrester 2014-09-16 22:36:33 UTC 
All patches merged (or abandoned, in the case of the broken SemanticResultFormats):

https://gerrit.wikimedia.org/r/#/q/bug:70615,n,z
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links