Last modified: 2014-09-05 21:04:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72462, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70462 - CentralNotice: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from upload.wikimedia.org
CentralNotice: $wgNoticeCloseButton shouldn't load closeWindow19x19.png from ...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2014-09-05 21:03 UTC by Krinkle
Modified: 2014-09-05 21:04 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2014-09-05 21:03:22 UTC 
A bit odd to see it load an image from a url.

> $wgNoticeCloseButton = '//upload.wikimedia.org/wikipedia/foundation/2/20/CloseWindow19x19.png';

The image is part of MediaWiki core, so there's a stable url it could use to load it from the local wiki (it's in skins/common/).

But instead of loading it from the local wiki, or from bits.wikimedia.org, or Wikimedia Commons, it loads it from foundationwiki.

Let's not do that. Since skins/common has been deprecated, this should just be added to  the extension.

Better yet, why is it configurable? Sounds like it shouldn't be an <img> either, but just somewhere in a CSS background-image, with @embed for automatic optimised loading via ResourceLoader (embedded in CSS, no extra http request).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links