Last modified: 2014-09-18 05:38:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72404, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70404 - Input fields should be relative to input strings
Input fields should be relative to input strings
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
MediaWiki UI (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 70425 (view as bug list)
Depends on:
Blocks: 70424 70913 70405
  Show dependency treegraph
 
Reported: 2014-09-04 16:57 UTC by Jared Zimmerman (WMF)
Modified: 2014-09-18 05:38 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
fields are too long (59.63 KB, image/png)
2014-09-04 16:57 UTC, Jared Zimmerman (WMF)
Details

Description Jared Zimmerman (WMF) 2014-09-04 16:57:25 UTC
Created attachment 16370 [details]
fields are too long

input fields are unreasonably long on http://mwui.wmflabs.org/wiki/Special:Preferences#mw-prefsection-editing

Editor Columns and Rows supports a max value of 1000, e.g. 4 characters, the input fields should limit input to 4 characters and be sized such that 4 characters fit comfortably ~70 pixels in length.
Comment 1 Jon 2014-09-04 17:35:45 UTC
In the style guide inputs are defined as having a width of 100% of the containing element.

We probably need a modifier for these types of input e.g. mw-ui-input q small ?
Comment 2 Jon 2014-09-04 17:38:00 UTC
Note we could use the size attribute but it's not clear how this would work on a mobile device/in a responsive layout.
Comment 3 Jared Zimmerman (WMF) 2014-09-04 17:56:56 UTC
I wasn't saying the field should be less tall, rather less wide. A standard control is good, just needs to hold fewer characters.
Comment 4 Jon 2014-09-05 08:22:50 UTC
*** Bug 70425 has been marked as a duplicate of this bug. ***
Comment 5 Jon 2014-09-16 23:23:24 UTC
I know. Width 100% = wide.

What should the size be? Should small be the default or should big be the default for input fields?
Comment 6 Jared Zimmerman (WMF) 2014-09-16 23:30:41 UTC
The input field should suggest to the user the type of content that should be entered. There is no hard and fast rule for open ended fields, however fields with structured input (character limited) should support the number of characters allowed plus consistent padding.
Comment 7 Jon 2014-09-16 23:52:16 UTC
*** Bug 70405 has been marked as a duplicate of this bug. ***
Comment 8 Jon 2014-09-16 23:52:50 UTC
As another example as pointed out by Jared this happens here"

Special:Preferences => Appearance tab => Time offset => Other (specify offset)

Then, the text field below is too long.
Comment 9 Jon 2014-09-17 00:26:21 UTC
Let's apply the mw-ui-inline class and see how that looks. 
http://tools.wmflabs.org/styleguide/desktop/section-1.html#section-1.1
Comment 10 Gerrit Notification Bot 2014-09-17 18:52:28 UTC
Change 161016 had a related patch set uploaded by Prtksxna:
inputs.less: Use .mw-ui-input-inline for type="number"

https://gerrit.wikimedia.org/r/161016
Comment 11 Gerrit Notification Bot 2014-09-17 23:10:22 UTC
Change 161016 merged by jenkins-bot:
inputs.less: Use .mw-ui-input-inline for type="number"

https://gerrit.wikimedia.org/r/161016

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links