Last modified: 2014-10-14 17:38:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72375, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70375 - VisualEditor: Deleting from an empty paragraph to the end of an inline node throws an exception
VisualEditor: Deleting from an empty paragraph to the end of an inline node t...
Status: PATCH_TO_REVIEW
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-nextup
Assigned To: Ed Sanders
:
Depends on:
Blocks: ve-tablesupport
  Show dependency treegraph
 
Reported: 2014-09-04 00:49 UTC by WhatamIdoing
Modified: 2014-10-14 17:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-09-04 00:49:06 UTC
See https://en.wikipedia.org/wiki/File:VisualEditorTableCopyBugScreenshot.jpg for what the editor selected.  See https://en.wikipedia.org/wiki/File:VisualEditorTableCopyBugScreenshot2.jpg (top) for what he got when he pasted it into the new place.

This was found on Chrome and Windows 7.

Also, if he used Ctrl-X to cut the table, he was unable to save his changes.  Clicking on the Save button did nothing after that point.  Ctrl-C to copy the table did not disable the Save button.
Comment 1 WhatamIdoing 2014-09-05 00:05:04 UTC
Update:

To make this work, you have to select the table (just its own cells), without any text before and after.

If you select more than the table (text + table + more text), then the table formatting appears to be correct when pasted in VisualEditor, but isn't actually correct when it's saved.  See https://en.wikipedia.org/w/index.php?oldid=624091874 for the saved version, and compare it to the same table in previous versions.  

In addition to not being able to save after cutting and pasting, it's not possible to switch to source code editing.
Comment 2 WhatamIdoing 2014-09-05 17:09:15 UTC
The problem appears after the cutting, not after the pasting.  Also, it's usually possible to switch to source editing.  Consequently, this is only a lost-work bug for most people (anyone who doesn't know about or doesn't try switching to source.)
Comment 3 Ed Sanders 2014-09-05 18:34:58 UTC
Minimal failure case in core to trigger the unbalanced delete which is causing this to happen:

<p></p>
<p>a<span rel="ve:Alien">b</span></p>

Select from the empty paragraph to after the b (range 1,6) and delete.
Comment 4 Gerrit Notification Bot 2014-09-05 18:55:00 UTC
Change 158662 had a related patch set uploaded by Esanders:
WIP Failing test case

https://gerrit.wikimedia.org/r/158662

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links