Last modified: 2014-10-02 06:58:00 UTC
When the Flow inline styles moved to core, we lost the hover behavior for neutral inline quiet anchors, i.e. woith no mw-ui-{progressive|constructive|destructive} colorizing class, just class="mw-ui-quiet". Without a hover behavior, a neutral quiet anchor seems dead. Neutral quiet anchors used to lighten @colorLightenPercentage on hover, now the generated CSS has separate rules for mw.ui-quiet and mw-ui-quiet:hover but they end up with the same color #666666 (@colorTextLight). Also, quiet anchors get a dotted outline on click because they don't have outline: none on focus and active. This would be easier to notice if the generated KSS at http://tools.wmflabs.org/styleguide/desktop/section-6.html had a sample showing <a class="mw-ui-quiet">Neutral (plain)</a>. The way the KSS is set up mw-ui-quiet is a modifier of a regular link. OR... Maybe we don't need to support .mw-ui-quiet on its own, and all quiet links must pick a color class. May Galloway has asked for some quiet links to be gray on hover, but currently Flow's Reply • Edit • Thank inline links are all colored..
mw-ui-quiet is currently presented as a modifier so we shouldn't be supported .mw-ui-quiet on its own. that said mw-ui-progressive etc is presented as a modifier and as a component. Maybe we should think about introducing mw-ui-anchor and making mw-ui-progressive/contstructive etc modifiers to avoid this confusion ?
Jon makes a valid argument for introducing mw-ui-anchor. It will make it more consistent with how we use other mw-ui components.
Shahyar this is fixed no?
It has patches in progress. https://gerrit.wikimedia.org/r/#/c/155856/ https://gerrit.wikimedia.org/r/#/c/156162/
Please swap the order shahyar as per my comment so we can get this merged.
Change 155856 had a related patch set uploaded by Jdlrobson: Change mw-ui anchors to require mw-ui-anchor base class https://gerrit.wikimedia.org/r/155856
I'm hoping Matt can merge this patch now. It's been sitting here a while...
Change 155856 merged by jenkins-bot: Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class https://gerrit.wikimedia.org/r/155856
