Last modified: 2014-08-03 23:01:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71083, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69083 - SpecialPagesWithProp uses implicit join
SpecialPagesWithProp uses implicit join
Status: NEW
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.23.1
All All
: High minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2014-08-03 22:22 UTC by Robert Morley
Modified: 2014-08-03 23:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robert Morley 2014-08-03 22:22:12 UTC
In the getQueryInfo() of SpecialPagesWithProp.php, the 'page_id = pp_page' represents an implicit join, which are generally frowned upon and reportedly can return a cross-join under some circumstances in SQL Server.

This portion of the 'conds' should be reimplemented under a 'join_conds' section.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links