Last modified: 2014-08-25 12:01:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 68998 - ULS: Fix "JQMIGRATE: jQuery.fn.attr('selected')" in ext.uls.displaysettings.js
ULS: Fix "JQMIGRATE: jQuery.fn.attr('selected')" in ext.uls.displaysettings.js
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Santhosh Thottingal
: easy, javascript
Depends on:
Blocks: code_quality jqmigrate
  Show dependency treegraph
 
Reported: 2014-08-01 11:10 UTC by Krinkle
Modified: 2014-08-25 12:01 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2014-08-01 11:10:14 UTC
For dynamic state always use properties. Attributes are for the DOM, not for the live display. Older versions of jQuery used to cover this common mistake by setting the property in addition to the attribute when setting the attribute, but this has all sorts of nasty side-effects. Use prop('selected', value) instead for this, and pass it a boolean true/false value (so not "" or "selected").
Comment 1 Gerrit Notification Bot 2014-08-25 11:44:37 UTC
Change 156092 had a related patch set uploaded by Santhosh:
Use prop instead of attr for changing 'selected' state

https://gerrit.wikimedia.org/r/156092
Comment 2 Gerrit Notification Bot 2014-08-25 11:50:23 UTC
Change 156092 merged by jenkins-bot:
Use prop instead of attr for changing 'selected' state

https://gerrit.wikimedia.org/r/156092

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links