Last modified: 2014-10-16 07:55:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70521, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68521 - Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Special:UserLogin]]
Global CSS and JS should not be loaded on [[Special:Preferences]] and [[Speci...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GlobalCssJs (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 70672
Blocks: 57891
  Show dependency tree / graph
 
Reported: 2014-07-24 18:26 UTC by Helder
Modified: 2014-10-16 07:55 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Comment 1 Helder 2014-07-24 18:39:19 UTC 
The fix would probably be similar to
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/64670
Comment 2 Kunal Mehta (Legoktm) 2014-07-24 18:40:33 UTC 
OutputPage::makeResourceLoaderLink should handle this properly, I'm looking into why it isn't.
Comment 3 Kunal Mehta (Legoktm) 2014-07-24 20:00:04 UTC 
https://github.com/wikimedia/mediawiki-core/blob/master/includes/OutputPage.php#L2726 isn't checking TYPE_COMBINED, which our global user module is using.
Comment 4 Gerrit Notification Bot 2014-07-24 23:05:38 UTC 
Change 149185 had a related patch set uploaded by Legoktm:
Check whether TYPE_COMBINED modules are allowed to be included in the page

https://gerrit.wikimedia.org/r/149185
Comment 5 Gerrit Notification Bot 2014-07-30 00:24:18 UTC 
Change 150442 had a related patch set uploaded by Legoktm:
Use OutputPage::addModuleStyles/Scripts to add modules

https://gerrit.wikimedia.org/r/150442
Comment 6 Gerrit Notification Bot 2014-07-30 00:33:16 UTC 
Change 150442 merged by jenkins-bot:
Use OutputPage::addModuleStyles/Scripts to add modules

https://gerrit.wikimedia.org/r/150442
Comment 7 Helder 2014-09-10 18:05:14 UTC 
My global CSS is loaded on Special Preferences (both on Meta and other wikis).
Comment 8 Helder 2014-09-10 18:10:07 UTC 
On
https://meta.wikimedia.org/wiki/Special:Preferences#mw-prefsection-rendering
I get this in the console (on Firefox):
> mw.loader.getState('ext.globalCssJs.user') === "registered"
> true
and
https://bits.wikimedia.org/meta.wikimedia.org/load.php?debug=false&lang=pt&modules=ext.globalCssJs.user&only=styles&skin=vector&user=Helder.wiki&version=20140826T153947Z&*
is still loaded.
Comment 9 Kunal Mehta (Legoktm) 2014-09-10 18:10:36 UTC 
I can't reproduce right now, but moving to the security component just in case.
Comment 10 Kunal Mehta (Legoktm) 2014-09-10 18:14:25 UTC 
Okay, I can confirm my global CSS is being loaded, but not JS. Investigating...
Comment 11 Kunal Mehta (Legoktm) 2014-09-10 18:50:13 UTC 
(In reply to Kunal Mehta (Legoktm) from comment #10)
> Okay, I can confirm my global CSS is being loaded, but not JS.
> Investigating...

See bug 70672.
Comment 12 Kunal Mehta (Legoktm) 2014-09-26 17:22:11 UTC 
This is fixed with the patch applied in bug 70672.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links