Last modified: 2014-09-20 21:11:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70326, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68326 - External link icon is not flipped in RTL
External link icon is not flipped in RTL
Status: RESOLVED DUPLICATE of bug 66091
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.24rc
All All
: High minor (vote)
: 1.24.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-21 15:48 UTC by Yair Rand
Modified: 2014-09-20 21:11 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yair Rand 2014-07-21 15:48:08 UTC
(Sorry if ResourceLoader isn't the right component for this.)

In RTL wikis, the icon displayed next to external links (with the class .external)  is backwards for browsers that support data URIs. (That is, it's displaying the same image as is displayed for LTR wikis.)

The CSS code does have the correct image (skins/Vector/images/external-link-rtl-icon.png) in the code within the ordinary url(//bits.wikimedia...), but the embedded version isn't actually of that image. Instead, it's embedding skins/Vector/images/external-link-ltr-icon.png .
Comment 1 Gerrit Notification Bot 2014-09-18 15:13:58 UTC
Change 161245 had a related patch set uploaded by Bartosz Dziewoński:
Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions

https://gerrit.wikimedia.org/r/161245
Comment 2 Bartosz Dziewoński 2014-09-18 15:15:59 UTC
Sorry it took so long. The fix is now available and should be applied within days (or weeks, top).
Comment 3 Krinkle 2014-09-18 17:24:50 UTC
These aren't really dependant, it's just the same thing for a specific image. Duping instead.

*** This bug has been marked as a duplicate of bug 66091 ***
Comment 4 Gerrit Notification Bot 2014-09-20 20:59:48 UTC
Change 161751 had a related patch set uploaded by Krinkle:
Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions

https://gerrit.wikimedia.org/r/161751
Comment 5 Gerrit Notification Bot 2014-09-20 21:05:41 UTC
Change 161245 merged by jenkins-bot:
Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions

https://gerrit.wikimedia.org/r/161245
Comment 6 Gerrit Notification Bot 2014-09-20 21:07:09 UTC
Change 161751 merged by jenkins-bot:
Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions

https://gerrit.wikimedia.org/r/161751
Comment 7 Bartosz Dziewoński 2014-09-20 21:11:53 UTC

*** This bug has been marked as a duplicate of bug 66091 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links