Last modified: 2014-07-16 21:55:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69042, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67042 - Allow HTML5 <rtc> tag (ruby support for East Asian typography)
Allow HTML5 <rtc> tag (ruby support for East Asian typography)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: 1.24.0 release
Assigned To: C. Scott Ananian
: i18n
Depends on:
Blocks: html5
  Show dependency treegraph
 
Reported: 2014-06-24 18:14 UTC by C. Scott Ananian
Modified: 2014-07-16 21:55 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Current rendering of ruby samples in IE 11 & dev preview with patch (466.43 KB, image/png)
2014-07-01 23:10 UTC, Brion Vibber
Details
Screenshot of ruby examples in current Safari 7.0.5 (510.31 KB, image/png)
2014-07-01 23:16 UTC, Brion Vibber
Details

Description C. Scott Ananian 2014-06-24 18:14:29 UTC
The HTML5 spec contains an <rtc> element (http://www.w3.org/TR/html5/text-level-semantics.html#the-rtc-element) as part of its ruby support.  We currently allow <ruby>, <rt>, <rp>, and <rb> but not <rtc>.
Comment 1 Gerrit Notification Bot 2014-06-24 18:21:38 UTC
Change 141742 had a related patch set uploaded by Cscott:
Allow HTML5 <rtc> tag (ruby support for East Asian typography).

https://gerrit.wikimedia.org/r/141742
Comment 2 C. Scott Ananian 2014-06-24 20:41:44 UTC
Hm.  The W3C and WHATWG seem to disagree about the status of <rb> and <rtc>.  See https://www.w3.org/Bugs/Public/show_bug.cgi?id=26187 and https://www.w3.org/Bugs/Public/show_bug.cgi?id=26189

Both Firefox and Chrome seems to follow the WHATWG, not the W3C.  That is, they parse:
  <ruby><rb>foo<rp>bar</ruby>
"incorrectly" as:
  <ruby><rb>foo<rp>bar</rp></rb></ruby></div>

According to the W3C, the <rb> tag should be closed before the <rp>.

So... I'm not sure it's a good idea to add the <rtc> tag at this time.  The right thing to do might be to *remove* the <rb> tag, to make us match WHATWG's spec (which lists <rb> explicitly as "non-conforming" in http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#non-conforming-features ).
Comment 3 C. Scott Ananian 2014-06-25 14:58:58 UTC
OK, got confirmation (mostly via twitter (!)) that webkit and gecko are on-board with the W3C's rb/rtc changes.  See:

https://twitter.com/cscottnet/status/481534354842484736
https://bugs.webkit.org/show_bug.cgi?id=131175
https://bugzilla.mozilla.org/show_bug.cgi?id=664104

So I guess we can go ahead with the patch in  https://gerrit.wikimedia.org/r/141742

Once this lands in core, we'll need corresponding patches for Parsoid and the domino and html5 packages (@robinberjon has offered to help with the latter two).
Comment 4 C. Scott Ananian 2014-06-25 15:17:20 UTC
@Hixie agrees! https://twitter.com/Hixie/status/481813810659880960
Comment 5 C. Scott Ananian 2014-06-25 15:26:39 UTC
Well, "agrees" might be too strong a term: https://bugzilla.mozilla.org/show_bug.cgi?id=664104#c35
Comment 6 Gerrit Notification Bot 2014-06-26 23:21:52 UTC
Change 142455 had a related patch set uploaded by Cscott:
Allow HTML5 <rtc> tag (ruby support for East Asian typography).

https://gerrit.wikimedia.org/r/142455
Comment 7 Brion Vibber 2014-07-01 23:10:47 UTC
Created attachment 15809 [details]
Current rendering of ruby samples in IE 11 & dev preview with patch

Just for reference, here's a screenshot of the ruby examples in the parserTests.txt file rendered on a wiki (with the patch on) in IE 11 (Windows 8.1 Update) and IE Developer Preview.

The "double-sided ruby" with the 'San Francisco' translation is the one using the new <rtc> element, and as expected renders the second ruby line not as a ruby line since IE 11 doesn't know about <rtc>.

The others all render as expected, which is not surprising as the HTML ruby spec is apparently based on IE's implementation. ;)
Comment 8 Brion Vibber 2014-07-01 23:16:07 UTC
Created attachment 15810 [details]
Screenshot of ruby examples in current Safari 7.0.5

For reference again, the ruby samples from the parser test case copied into a wiki page (with the patch) and rendered in Safari. Current Chrome appears about the same, including current Canary builds.

Note that in addition to the <rtc> not being supported yet and rendering outside the ruby area (as expected), the "inline" and jukugo forms do *not* render correctly in Safari/WebKit or Chrome/Blink -- the annotations "spill over" and align incorrectly.

(Also note that latest FirefoxNightly parses the ruby elements but doesn't *render* them as anything but plain text yet.)
Comment 9 Gerrit Notification Bot 2014-07-08 19:10:56 UTC
Change 141742 merged by Brion VIBBER:
Allow HTML5 <rtc> tag (ruby support for East Asian typography).

https://gerrit.wikimedia.org/r/141742
Comment 10 Gerrit Notification Bot 2014-07-08 19:46:30 UTC
Change 144745 had a related patch set uploaded by Cscott:
Add <rtc> tag support to RELEASE-NOTES-1.24.

https://gerrit.wikimedia.org/r/144745
Comment 11 Gerrit Notification Bot 2014-07-08 19:51:00 UTC
Change 144745 merged by jenkins-bot:
Add <rtc> tag support to RELEASE-NOTES-1.24.

https://gerrit.wikimedia.org/r/144745
Comment 12 Gerrit Notification Bot 2014-07-10 17:46:04 UTC
Change 142455 merged by jenkins-bot:
Allow HTML5 <rtc> tag (ruby support for East Asian typography).

https://gerrit.wikimedia.org/r/142455

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links