Last modified: 2014-06-18 02:48:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68646, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66646 - Refactor out 'infinity' variants
Refactor out 'infinity' variants
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Lowest minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2014-06-15 23:57 UTC by Sam Reed (reedy)
Modified: 2014-06-18 02:48 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2014-06-15 23:57:15 UTC 
In ProtectionForm:
if ( $value == 'infinite' || $value == 'indefinite' || $value == 'infinity' ) {

In ApiProtect:
if ( in_array( $expiry[$i], array( 'infinite', 'indefinite', 'infinity', 'never' ) ) ) {


There's a few places in the code we check for these variants of infinity. They should be refactored out
Comment 1 Gerrit Notification Bot 2014-06-18 02:48:51 UTC 
Change 140276 had a related patch set uploaded by devunt:
Refactor out 'infinity' variants

https://gerrit.wikimedia.org/r/140276
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links