Last modified: 2014-06-18 02:48:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 66646 - Refactor out 'infinity' variants
Refactor out 'infinity' variants
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Lowest minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: code_quality
  Show dependency treegraph
Reported: 2014-06-15 23:57 UTC by Sam Reed (reedy)
Modified: 2014-06-18 02:48 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Sam Reed (reedy) 2014-06-15 23:57:15 UTC
In ProtectionForm:
if ( $value == 'infinite' || $value == 'indefinite' || $value == 'infinity' ) {

In ApiProtect:
if ( in_array( $expiry[$i], array( 'infinite', 'indefinite', 'infinity', 'never' ) ) ) {

There's a few places in the code we check for these variants of infinity. They should be refactored out
Comment 1 Gerrit Notification Bot 2014-06-18 02:48:51 UTC
Change 140276 had a related patch set uploaded by devunt:
Refactor out 'infinity' variants

Note You need to log in before you can comment on or make changes to this bug.