Last modified: 2014-05-30 22:09:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67562, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65562 - PDF Rendering page no longer refreshes
PDF Rendering page no longer refreshes
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Collection (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Bartosz Dziewoński
: browser-test-bug
: 65943 (view as bug list)
Depends on:
Blocks: jqmigrate
  Show dependency treegraph
 
Reported: 2014-05-20 22:47 UTC by Chris McMahon
Modified: 2014-05-30 22:09 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2014-05-20 22:47:50 UTC
seen in test2wiki/mw.o since 15 May and also beta labs

Pick any page for example http://test2.wikipedia.org/wiki/LowTemplate

Click Download as PDF 

Get the Rendering page showing 1% progress. 

Rendering page never refreshes.  

Note that the Rendering page does say "This page should automatically refresh every few seconds. If this does not work, please press your browser's refresh button." and upon refreshing the page the PDF file is available for download.
Comment 1 Chris McMahon 2014-05-20 22:49:34 UTC
Note: not seen in production
Comment 2 Greg Grossmeier 2014-05-21 17:37:05 UTC
Putting into the Collection (PDF) extension for now, for visibility.
Comment 3 Chris McMahon 2014-05-23 17:34:13 UTC
This seems to have been deployed to production, I just checked enwiki and PDF Rendering page no longer refreshes automatically in my browser.
Comment 4 Greg Grossmeier 2014-05-23 18:07:43 UTC
Matt/Chad: Could you take a look at this? I picked you two because I like you (and not sure who else to turn to). :)
Comment 5 Helder 2014-05-30 15:26:32 UTC
*** Bug 65943 has been marked as a duplicate of this bug. ***
Comment 6 Helder 2014-05-30 15:27:34 UTC
(copied from bug 65943)

After I loaded
http://en.wikipedia.beta.wmflabs.org/wiki/Cat
and clicked on "Download as PDF" I got the URL
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Book&bookcmd=render_article&arttitle=Cat&oldid=68036&writer=rl
where I get this:
"Exception thrown by ext.collection.bookcreator" load.php:160
"Error: Syntax error, unrecognized expression: #bodyContent a[href^='/wiki/']:not(a[href~='index.php'])[title!=][rel!=nofollow]:not(.external):not(.internal):not(.sortheader):not([accesskey]):not(.nopopup)" Error: Syntax error, unrecognized expression: #bodyContent a[href^='/wiki/']:not(a[href~='index.php'])[title!=][rel!=nofollow]:not(.external):not(.internal):not(.sortheader):not([accesskey]):not(.nopopup)
Stack trace:
Sizzle</Sizzle.error@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:20
Sizzle</Sizzle.tokenize@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:29
Sizzle</Sizzle.select@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:35
Sizzle@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:12
.find@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:39
jQuery.fn.init@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:40
jQuery.fn.init@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:154
jQuery@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:1
@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=ext.collection%7Cext.collection.bookcreator&skin=vector&version=20140421T170058Z&*:9
jQuery.Callbacks/fire@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:44
jQuery.Callbacks/self.add@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:45
jQuery.fn.ready@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:48
jQuery.fn.init@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:41
jQuery.fn.init@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:154
jQuery@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:1
@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=ext.collection%7Cext.collection.bookcreator&skin=vector&version=20140421T170058Z&*:6
@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=ext.collection%7Cext.collection.bookcreator&skin=vector&version=20140421T170058Z&*:9
runScript@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:170
execute/</checkCssHandles@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:171
execute/</cssHandle/<@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:171
jQuery.Callbacks/fire@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:44
jQuery.Callbacks/self.fireWith@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:46
jQuery.Callbacks/self.fire@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:46
addEmbeddedCSS@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:166
addEmbeddedCSS/<@http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20140518T101426Z:165


I believe this is the cause of the problem mentioned by Matthew Walker on
http://lists.wikimedia.org/pipermail/wikitech-l/2014-May/076734.html
Comment 8 Nemo 2014-05-30 16:59:40 UTC

*** This bug has been marked as a duplicate of bug 36962 ***
Comment 9 Bartosz Dziewoński 2014-05-30 17:18:39 UTC
This is not a duplicate or I am missing something. That bug has nothing about JavaScript errors on it.
Comment 10 Bartosz Dziewoński 2014-05-30 17:20:18 UTC
This is probably caused by the recent jQuery update. Collection has some clever code that should have never worked if you ask me, and apparently stopped working now.

This is a one-line fix unless there is some other weirdness there (I've only dug into the traceback from comment 6).
Comment 11 Gerrit Notification Bot 2014-05-30 17:21:30 UTC
Change 136350 had a related patch set uploaded by Bartosz Dziewoński:
Use [title!=''] instead of [title!=] to make jQuery happy

https://gerrit.wikimedia.org/r/136350
Comment 12 Gerrit Notification Bot 2014-05-30 17:46:11 UTC
Change 136350 merged by jenkins-bot:
Use [title!=''] instead of [title!=] to make jQuery happy

https://gerrit.wikimedia.org/r/136350
Comment 13 Bartosz Dziewoński 2014-05-30 17:50:13 UTC
Thanks. Can you verify that this fixes the bug? As I said, I only looked at the single backtrace in the comments here, there might be more issues lurking.
Comment 14 Greg Grossmeier 2014-05-30 18:45:13 UTC
WFM now (tested the beta cluster Cats page).

The percentage done jumps around (goes back to 1% after hitting 20% or so, then up to 75%). But the page successfully autoreloads with the url to the pdf to download.

Progress bars are tough, so I'm not going to hold this back in anyway. Get the required functionality back.
Comment 15 Greg Grossmeier 2014-05-30 22:09:05 UTC
Ok, just did another one. I'm calling this fixed.

Matma: if you want to backport, want to do it early next week?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links