Last modified: 2014-07-29 19:39:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67487, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65487 - OggHandler should pass jshint
OggHandler should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OggHandler (Other open bugs)
unspecified
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint 64990
  Show dependency tree / graph
 
Reported: 2014-05-19 14:42 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-07-29 19:39 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-05-19 14:42:37 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-05-19 14:45:30 UTC 
Change 134096 had a related patch set uploaded by Hashar:
mwext-OggHandler-jslint non voting

https://gerrit.wikimedia.org/r/134096
Comment 2 Gerrit Notification Bot 2014-05-19 14:46:11 UTC 
Change 134096 merged by jenkins-bot:
mwext-OggHandler-jslint non voting

https://gerrit.wikimedia.org/r/134096
Comment 3 Bawolff (Brian Wolff) 2014-05-19 16:58:23 UTC 
For reference, we no longer use this extension, and it is extremely unlikely we ever will in the future, as its functionality has been replaced by TimedMediaHandler. I doubt this extension is going to get much new development effort.
Comment 4 Gerrit Notification Bot 2014-05-19 19:27:46 UTC 
Change 134164 had a related patch set uploaded by Hashar:
Pass jshint

https://gerrit.wikimedia.org/r/134164
Comment 5 Antoine "hashar" Musso (WMF) 2014-05-19 19:29:58 UTC 
Made it pass jshint with the very conservative patch: https://gerrit.wikimedia.org/r/#/c/134164/
Comment 6 Gerrit Notification Bot 2014-05-20 14:46:49 UTC 
Change 134164 merged by jenkins-bot:
Pass jshint

https://gerrit.wikimedia.org/r/134164
Comment 7 Gerrit Notification Bot 2014-05-20 15:02:00 UTC 
Change 134368 had a related patch set uploaded by Hashar:
mwext-OggHandler-jslint is now voting

https://gerrit.wikimedia.org/r/134368
Comment 8 Gerrit Notification Bot 2014-05-20 15:03:11 UTC 
Change 134368 merged by jenkins-bot:
mwext-OggHandler-jslint is now voting

https://gerrit.wikimedia.org/r/134368
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links