Last modified: 2014-05-22 00:05:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67243, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65243 - Flow: Obey the Exlinks gadget (open external links in new tab/window)
Flow: Obey the Exlinks gadget (open external links in new tab/window)
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 56756
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-13 00:01 UTC by Quiddity
Modified: 2014-05-22 00:05 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quiddity 2014-05-13 00:01:15 UTC
The gadget exlinks https://en.wikipedia.org/wiki/MediaWiki:Gadget-exlinks.js
is not being obeyed.

(24,000+ accounts have it enabled at Enwiki https://en.wikipedia.org/wiki/Wikipedia:Database_reports/User_preferences 
and 35,000 Globally, making it the 6th most popular Wikipedia gadget https://meta.wikimedia.org/wiki/Gadgets/wikipedia )
Comment 1 Quiddity 2014-05-13 00:08:54 UTC
Note: Bug submitted on behalf of this issue raised by Risker:

"It is not possible to examine an external link before clicking on it, so one has to trust that the person who inserted the link will not send the reader to a site that might be a problem for that reader. Gonna be honest, there aren't a lot of people I trust that well; even people I know who have acted in good faith have inserted links that I don't want to follow or that will create problems for some users.  [Note: admins can click "edit" and see the link, but non-admins cannot do so]"

See the related bug 60465 ("provide View Source (showing the wikitext) of someone's post") for another way to partially resolve this issue.
Comment 2 Erik Bernhardson 2014-05-13 00:11:51 UTC
you could just change the selector from $('a.external') to $('a.external, a[rel="mw:ExtLink"]'). then it would work for all parsoid content, but i don't have an edit button for that gadget.

As an aside, in desktop browsers you can typically see where a link goes by hovering it and looking at the bar on the bottom of the browser(in chrome and firefox, maybe others).
Comment 3 Kunal Mehta (Legoktm) 2014-05-15 07:18:20 UTC
(In reply to Erik Bernhardson from comment #2)
> you could just change the selector from $('a.external') to $('a.external,
> a[rel="mw:ExtLink"]'). then it would work for all parsoid content, but i
> don't have an edit button for that gadget.

Why isn't parsoid adding the 'external' class?
Comment 4 Kunal Mehta (Legoktm) 2014-05-15 07:22:34 UTC
(In reply to Kunal Mehta (Legoktm) from comment #3)

> Why isn't parsoid adding the 'external' class?

Hmm, this is also tracked as bug 56756 in Flow which is blocked by 51245 in Parsoid.
Comment 5 spage 2014-05-22 00:05:47 UTC
I don't think Parsoid is going to change its HTML output, so I suggested making the fix to the gadget's JS code from comment #2 on the gadget's talk page <https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-exlinks.js#Fix_to_support_Parsoid_external_links>

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links