Last modified: 2014-08-26 03:49:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 64745 - Math button's position unpredictible due to asynchronous load of toolbar parts
Math button's position unpredictible due to asynchronous load of toolbar parts
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Math (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: edit-toolbar
  Show dependency treegraph
 
Reported: 2014-05-02 15:35 UTC by Juan de Vojníkov
Modified: 2014-08-26 03:49 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Czech Wikiversity, position of Math button at old edit toolbar. FF 29.0 (47.99 KB, image/jpeg)
2014-05-04 07:18 UTC, Juan de Vojníkov
Details
cs.wv position of match button at old edit toolbar, Google Chrome 34.0.1847.131 m (35.70 KB, image/jpeg)
2014-05-04 07:19 UTC, Juan de Vojníkov
Details

Description Juan de Vojníkov 2014-05-02 15:35:21 UTC
Math edit button:
https://commons.wikimedia.org/wiki/File:Button_math.png

in MediaWiki edit button toolbar migrated from its standart position to the first position (to left on Czech projects in FF 28.0) and to the last postion (Czech language, Google Chrome). Please move it back to its possition.
Comment 1 Andre Klapper 2014-05-02 15:42:52 UTC
Please provide steps to reproduce.
Comment 2 Juan de Vojníkov 2014-05-02 17:23:36 UTC
1) Login in to cs.wv
2) Preference- Editing - disable Enable enhanced editing toolbar
3) open this page: https://cs.wikiversity.org/w/index.php?title=Diskuse_s_u%C5%BEivatelem:Danny_B.&action=edit&section=20
Comment 3 Andre Klapper 2014-05-03 16:31:44 UTC
I have disabled "Enable enhanced editing toolbar" and opened the URL. I have no idea where and how to see a Math button, so the steps to reproduce miss some steps.
Comment 4 Andre Klapper 2014-05-03 16:35:15 UTC
I disabled also "Show edit toolbar" but I have no idea how to get that ancient non-WikiEditor toolbar displayed that you might talk about (no idea, as no screenshot provided).
Comment 5 Juan de Vojníkov 2014-05-04 07:18:36 UTC
Created attachment 15287 [details]
Czech Wikiversity, position of Math button at old edit toolbar. FF 29.0
Comment 6 Juan de Vojníkov 2014-05-04 07:19:44 UTC
Created attachment 15288 [details]
cs.wv position of match button at old edit toolbar, Google Chrome 34.0.1847.131 m
Comment 7 Andre Klapper 2014-05-05 12:55:29 UTC
I can confirm the problem (see below). CC'ing Math folks - any idea if something has changed in Math here that could have triggered this?


To reproduce: I disabled "Zapnout vylepšený panel nástrojů" now on https://cs.wikiversity.org/wiki/Speci%C3%A1ln%C3%AD:Nastaven%C3%AD#mw-prefsection-editing (sorry, I had interpreted "wv" as wikivoyage before, not as wikiversity; that's why I couldn't reproduce).
Comment 8 Juan de Vojníkov 2014-05-05 13:12:45 UTC
(In reply to Andre Klapper from comment #7)
> I can confirm the problem (see below). CC'ing Math folks - any idea if
> something has changed in Math here that could have triggered this?
> 
> 
> To reproduce: I disabled "Zapnout vylepšený panel nástrojů" now on
> https://cs.wikiversity.org/wiki/Speci%C3%A1ln%C3%AD:Nastaven%C3%AD#mw-
> prefsection-editing (sorry, I had interpreted "wv" as wikivoyage before, not
> as wikiversity; that's why I couldn't reproduce).

Well, I think the problem is broad. I think I saw it also on other project and I spoke about it with somone on IRC, that they saw it elsewhere. But without testing I cannot prove it.
Comment 9 physikerwelt 2014-05-05 15:01:43 UTC
Yes. The code that creates the Math button was moved from core to the Math extension in https://gerrit.wikimedia.org/r/#/c/109923/
Comment 10 Helder 2014-05-05 15:12:25 UTC
There is no way to specify the order of buttons in the (classic) toolbar, other than adding them (with mw.toolbar.addButton) in the desired order. Since the loading order of MW modules is decided by ResourceLoader, I believe the migration just made the code from Math extension to be executed earlier than it used to be when it was in core.

See also a similar "problem" (for the {{cite}} button) on this thread:
https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=607169851#The_little_toolbar_having_a_problem...
In that case, the button was previously added by a script, which was imported from MediaWiki:common.js, and the button moved to other position when the code was migrated into a RL-enabled gadget.
Comment 11 Juan de Vojníkov 2014-05-05 16:22:20 UTC
So it means, we can fix it in local javascript and there is no need to repair it internaly?
Comment 12 Danny B. 2014-05-10 18:33:27 UTC
This is currently known issue related to the asynchronous loading of the toolbar buttons provided by server (aka core and extensions).

DJ & Krinkle are jsut discussing this @ Hackathon...
Comment 13 Helder 2014-08-26 02:54:33 UTC
Maybe this could be solved by providing another hook inside of getEditToolbar to allow extensions to modify the content of $toolarray?
https://github.com/wikimedia/mediawiki-core/blob/master/includes/EditPage.php#L3641
Comment 14 Helder 2014-08-26 03:49:16 UTC
See also bug 28681 and r86942 (and then Gerrit change #16238).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links