Last modified: 2014-06-27 18:54:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66420, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64420 - RTL support in page body in the app (language variant issues)
RTL support in page body in the app (language variant issues)
Status: REOPENED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
Android (alpha)
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: rtl-android
  Show dependency treegraph
 
Reported: 2014-04-25 08:46 UTC by Liangent
Modified: 2014-06-27 18:54 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
RTL on LTR UI (141.01 KB, image/png)
2014-04-30 20:08 UTC, Yuvi Panda
Details

Description Liangent 2014-04-25 08:46:53 UTC
Previously I thought there must already be a bug... but I can't find it now?

RTL attribute must not be configured per site. Because of content handler and language converter, it's possible that some pages on a site are LTR, while some others are RTL.
Comment 1 Yuvi Panda 2014-04-25 21:06:59 UTC
Can you give me examples? Do we have sites that have different directionalities for different variants?
Comment 3 Liangent 2014-04-27 13:14:00 UTC
Just one more note: page footer needs to be treated separately, because it's in interface language instead of page body language, but it seems rendered together with page body.
Comment 4 Liangent 2014-04-30 17:33:20 UTC
@brion: the RTL issue exists even when the language converter is not involved.
Comment 5 Yuvi Panda 2014-04-30 17:34:47 UTC
Page footer should already be taking in interface language (dir set appropriately) and not as part of the content language. I did a pass for RTL issues with Amir a few weeks back, but more might have crept in. I'll take a look, but can you identify explicit issues?

And I don't think we'll be explicitly handling variant issues for this iteration :(
Comment 6 Liangent 2014-04-30 17:53:20 UTC
Huh don't you see anything in page content LTR even if a RTL wiki is being viewed in a RTL device?
Comment 7 Yuvi Panda 2014-04-30 20:08:09 UTC
Created attachment 15255 [details]
RTL on LTR UI
Comment 8 Yuvi Panda 2014-04-30 20:08:29 UTC
@liangent: Looks good to me? This was RTL wiki in LTR device.
Comment 9 Liangent 2014-05-01 02:40:41 UTC
(In reply to Yuvi Panda from comment #8)
> @liangent: Looks good to me? This was RTL wiki in LTR device.

Hmm it seems you're testing it using hi, but I'm using ar.
Comment 10 Yuvi Panda 2014-05-01 08:24:21 UTC
Indeed. I can repro LTR issues with ar. I'll take a look.
Comment 11 Gerrit Notification Bot 2014-05-28 02:10:09 UTC
Change 135730 had a related patch set uploaded by Yuvipanda:
Make sure Arabic wikipedia is classified as RTL

https://gerrit.wikimedia.org/r/135730
Comment 12 Gerrit Notification Bot 2014-05-28 16:40:05 UTC
Change 135730 merged by BearND:
Make sure Arabic wikipedia is classified as RTL

https://gerrit.wikimedia.org/r/135730
Comment 13 Dan Garry 2014-06-18 18:33:19 UTC
The patch was merged so this should be fixed.
Comment 14 Liangent 2014-06-18 18:42:40 UTC
It seems this bug has been hijacked with the ar issue which got resolved, but the original problem (content handler and language converter) is still there.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links