Last modified: 2014-06-27 18:54:22 UTC
Previously I thought there must already be a bug... but I can't find it now? RTL attribute must not be configured per site. Because of content handler and language converter, it's possible that some pages on a site are LTR, while some others are RTL.
Can you give me examples? Do we have sites that have different directionalities for different variants?
(In reply to Yuvi Panda from comment #1) > Can you give me examples? Do we have sites that have different > directionalities for different variants? kkwiki uses language converter for latn, cyrl and arab. latn and cyrl are ltr, while arab is rtl. https://kk.wikipedia.org/w/index.php?title=%D0%AF%D0%BD%D0%B3-%D0%AF%D1%85%D0%B0_%28%D0%AE%D1%80%D0%B5%D0%B4%D0%B5%D0%B9-%D0%AF%D1%85%D0%B0_%D1%82%D0%B0%D1%80%D0%BC%D0%B0%D2%93%D1%8B%29&variant=kk-latn https://kk.wikipedia.org/w/index.php?title=%D0%AF%D0%BD%D0%B3-%D0%AF%D1%85%D0%B0_%28%D0%AE%D1%80%D0%B5%D0%B4%D0%B5%D0%B9-%D0%AF%D1%85%D0%B0_%D1%82%D0%B0%D1%80%D0%BC%D0%B0%D2%93%D1%8B%29&variant=kk-arab
Just one more note: page footer needs to be treated separately, because it's in interface language instead of page body language, but it seems rendered together with page body.
@brion: the RTL issue exists even when the language converter is not involved.
Page footer should already be taking in interface language (dir set appropriately) and not as part of the content language. I did a pass for RTL issues with Amir a few weeks back, but more might have crept in. I'll take a look, but can you identify explicit issues? And I don't think we'll be explicitly handling variant issues for this iteration :(
Huh don't you see anything in page content LTR even if a RTL wiki is being viewed in a RTL device?
Created attachment 15255 [details] RTL on LTR UI
@liangent: Looks good to me? This was RTL wiki in LTR device.
(In reply to Yuvi Panda from comment #8) > @liangent: Looks good to me? This was RTL wiki in LTR device. Hmm it seems you're testing it using hi, but I'm using ar.
Indeed. I can repro LTR issues with ar. I'll take a look.
Change 135730 had a related patch set uploaded by Yuvipanda: Make sure Arabic wikipedia is classified as RTL https://gerrit.wikimedia.org/r/135730
Change 135730 merged by BearND: Make sure Arabic wikipedia is classified as RTL https://gerrit.wikimedia.org/r/135730
The patch was merged so this should be fixed.
It seems this bug has been hijacked with the ar issue which got resolved, but the original problem (content handler and language converter) is still there.