Last modified: 2014-11-17 20:58:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65959, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 63959 - EducationProgram should pass jshint


Summary:	EducationProgram should pass jshint

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	EducationProgram (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	https://integration.wikimedia.org/ci/...
Whiteboard:
Keywords:

Depends on:
Blocks:	jshint
	Show dependency tree / graph

Reported:	2014-04-15 19:15 UTC by Nemo
Modified:	2014-11-17 20:58 UTC (History)
CC List:	10 users (show)

See Also:	56962
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
From https://gerrit.wikimedia.org/r/#/c/125959/ (59.86 KB, text/plain) 2014-04-15 19:15 UTC, Nemo	Details
Add an attachment (proposed patch, testcase, etc.)

Description Nemo 2014-04-15 19:15:33 UTC

Created attachment 15107 [details]
From https://gerrit.wikimedia.org/r/#/c/125959/

18:18:40 resources/jquery.imageinput.js: line 37, col 14, Too many errors. (29% scanned).
18:18:40 
18:18:40 676 errors
18:18:40 Build step 'Execute shell' marked build as failure
18:18:40 Finished: FAILURE

Comment 1 Andrew Green 2014-04-15 19:46:26 UTC

Thanks! Since normally jslint passes for this extension, I'm changing this to a continuous integration bug.

Comment 2 Antoine "hashar" Musso (WMF) 2014-04-16 09:32:07 UTC

$ jshint --version
jshint v2.4.4
$ jshint .
..
resources/jquery.imageinput.js: line 37, col 14, Too many errors. (29% scanned).

676 errors
$

It does not pass on my machine :-/

Comment 3 Tony Thomas 2014-09-17 16:42:21 UTC

Still happened today in https://integration.wikimedia.org/ci/job/mwext-EducationProgram-jslint/692/console

Comment 4 Andrew Green 2014-09-17 17:11:37 UTC

For example, see https://gerrit.wikimedia.org/r/#/c/118101 . Patch set 9 fails but patch set 10 passes. No changes in js modules. Sorry I haven't had time to try to chase this down... Thanks!!! :)

Comment 5 Gerrit Notification Bot 2014-09-17 17:12:51 UTC

Change 160986 had a related patch set uploaded by 01tonythomas:
Added .jshintrc file to pass Jenkins

https://gerrit.wikimedia.org/r/160986

Comment 6 Antoine "hashar" Musso (WMF) 2014-09-18 08:33:00 UTC

Moving bug under MediaWiki extensions

Comment 7 Gerrit Notification Bot 2014-10-21 21:23:41 UTC

Change 167954 had a related patch set uploaded by Hashar:
Have Jenkins use the standard configuration for JSLint

https://gerrit.wikimedia.org/r/167954

Comment 8 Gerrit Notification Bot 2014-10-21 21:24:20 UTC

Change 167954 merged by jenkins-bot:
Have Jenkins use the standard configuration for JSLint

https://gerrit.wikimedia.org/r/167954

Comment 9 Gerrit Notification Bot 2014-10-22 03:54:40 UTC

Change 160986 abandoned by 01tonythomas:
Added .jshintrc file to pass Jenkins

Reason:
in favor of I1652e641f0a778db8a47ed8e5da00a31636c4f55

https://gerrit.wikimedia.org/r/160986

Comment 10 Andre Klapper 2014-11-15 12:20:50 UTC

All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Comment 11 Sage Ross 2014-11-17 17:45:08 UTC

It seems to be behaving lately, so I'll close it as fixed.

Comment 12 Antoine "hashar" Musso (WMF) 2014-11-17 20:35:06 UTC

CI is up to date :)

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links