Last modified: 2014-06-05 08:47:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65904, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63904 - The 'upright' option should use a square bounding box
The 'upright' option should use a square bounding box
Status: NEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: ---
Assigned To: C. Scott Ananian
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-14 15:02 UTC by C. Scott Ananian
Modified: 2014-06-05 08:47 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description C. Scott Ananian 2014-04-14 15:02:00 UTC
See https://www.mediawiki.org/wiki/Requests_for_comment/Square_bounding_boxes for context.

The "upright" option is currently misnamed: it doesn't do anything special for upright images, it just scales the default width-based thumbnail size.

It should use a square bounding box.
Comment 1 C. Scott Ananian 2014-04-14 15:18:50 UTC
I am gathering statistics on how many image sizes would be affected by changing upright to use square bounding boxes, and optionally also changing the default scale factor to 1.0 at the same time (assuming the default scale factor was mostly used for 3:4 portrait aspect-ratio images).  The statistics-gathering code can be found at https://github.com/cscott/wp-image-info

For frwiki, there are 1,242,985 references to non-commons images, of which 17,870 use the 'upright' specifier.  If upright were changed to use a square bounding box, 1049 would change size by more than 5px if the default scale factor was left at 0.75, and 1053 would change size by more than 5px if the default scale factor was changed to 1.00.

On dewiki, there are 1,786,779 references to non-commons images, of which 38,624 use the 'upright' specifier.  If upright were changed to use a square bounding box, 1963 would change size by more than 5px if the default scale factor was left at 0.75, and 1764 would change size by more than 5px if the default scale factor was changed to 1.00.

Statistics collection on enwiki is still ongoing.
Comment 2 Andre Klapper 2014-05-05 13:01:46 UTC
(In reply to C. Scott Ananian from comment #1)
> Statistics collection on enwiki is still ongoing.

Any news?
Comment 3 C. Scott Ananian 2014-05-14 00:28:46 UTC
For enwiki, there are 4,949,488 references to non-commons images, of which 37,185 use the 'upright' specifier.  If upright were changed to use a square bounding box, 1971 would change size by more than 5px if the default scale factor was left at 0.75, and 1866 would change size by more than 5px if the default scale factor was changed to 1.00.

So roughly 0.75% of the images on a wiki use upright, and 0.04% would change size if 'upright' used a square bounding box.

Given that the # of size changes are roughly comparable for the 0.75 and 1.00 default scale factor, I'd suggest that we should use the 1.00 scale factor, which will remove one more magical constant from wikitext semantics.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links