Last modified: 2014-03-31 13:37:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65221, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63221 - OAuth should pass jslint
OAuth should pass jslint
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
OAuth (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-03-28 11:00 UTC by Siebrand Mazeland
Modified: 2014-03-31 13:37 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2014-03-28 11:00:57 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-03-28 11:03:03 UTC 
Change 121636 had a related patch set uploaded by Siebrand:
Make jslint non-voting for OAuth

https://gerrit.wikimedia.org/r/121636
Comment 2 Gerrit Notification Bot 2014-03-28 14:57:59 UTC 
Change 121636 abandoned by Hashar:
Make jslint non-voting for OAuth

Reason:
OAuth is passing as shown on the last change merged in: https://gerrit.wikimedia.org/r/#/c/93918/

You probably got hit by https://bugzilla.wikimedia.org/show_bug.cgi?id=52456 which can be solved by added a dummy .jshintrc in the repository that would contain:
 {}

https://gerrit.wikimedia.org/r/121636
Comment 3 Antoine "hashar" Musso (WMF) 2014-03-28 14:58:28 UTC 
Closing bug per my comment above.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links