Last modified: 2014-03-28 14:20:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65219, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63219 - MarkAsHelpful should pass jslint
MarkAsHelpful should pass jslint
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
MarkAsHelpful (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: bsitu
:
Depends on:
Blocks: jshint
  Show dependency treegraph
 
Reported: 2014-03-28 10:29 UTC by Siebrand Mazeland
Modified: 2014-03-28 14:20 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2014-03-28 10:29:57 UTC
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-03-28 10:31:31 UTC
Change 121623 had a related patch set uploaded by Siebrand:
Make jslint non-voting for MarkAsHelpful

https://gerrit.wikimedia.org/r/121623
Comment 2 Gerrit Notification Bot 2014-03-28 14:19:30 UTC
Change 121623 abandoned by Hashar:
Make jslint non-voting for MarkAsHelpful

Reason:
MarkAsHelpful is passing as shown on the two last changes merged in: 

https://gerrit.wikimedia.org/r/#/c/58780/
https://gerrit.wikimedia.org/r/#/c/121609/

You probably got hit by https://bugzilla.wikimedia.org/show_bug.cgi?id=52456 which can be solved by added a dummy .jshintrc in the repository that would contain:

 {}

https://gerrit.wikimedia.org/r/121623
Comment 3 Antoine "hashar" Musso (WMF) 2014-03-28 14:20:05 UTC
Closing, per my comment on the Gerrit change.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links