Last modified: 2014-08-05 09:41:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65117, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63117 - FlaggedRevs should pass jshint
FlaggedRevs should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Alex Monk
:
Depends on:
Blocks: jshint
  Show dependency treegraph
 
Reported: 2014-03-26 16:35 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-08-05 09:41 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-03-26 16:35:24 UTC
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-03-27 09:16:41 UTC
Change 121099 had a related patch set uploaded by Hashar:
Make jslint non-voting for FlaggedRevs

https://gerrit.wikimedia.org/r/121099
Comment 2 Gerrit Notification Bot 2014-03-27 09:16:59 UTC
Change 121099 merged by jenkins-bot:
Make jslint non-voting for FlaggedRevs

https://gerrit.wikimedia.org/r/121099
Comment 3 Gerrit Notification Bot 2014-07-07 17:01:04 UTC
Change 144479 had a related patch set uploaded by Alex Monk:
Make FR pass jslint

https://gerrit.wikimedia.org/r/144479
Comment 4 Gerrit Notification Bot 2014-08-05 09:35:34 UTC
Change 151828 had a related patch set uploaded by Hashar:
mwext-FlaggedRevs-jslint is now voting

https://gerrit.wikimedia.org/r/151828
Comment 5 Gerrit Notification Bot 2014-08-05 09:35:57 UTC
Change 151828 merged by jenkins-bot:
mwext-FlaggedRevs-jslint is now voting

https://gerrit.wikimedia.org/r/151828
Comment 6 Antoine "hashar" Musso (WMF) 2014-08-05 09:36:27 UTC
Thank you!
Comment 7 Gerrit Notification Bot 2014-08-05 09:41:09 UTC
Change 144479 merged by jenkins-bot:
Make FR pass jslint

https://gerrit.wikimedia.org/r/144479

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links