Last modified: 2014-04-17 20:23:50 UTC
We're currently flooded by dozens of these per minute: 13.36 -rakkaus:#mediawiki-i18n- (10 lines skipped) [26-Mar-2014 12:36:16 UTC] PHP Strict Standards: Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res) in /www/translatewiki.net/w/extensions/CleanChanges/CleanChanges_body.php on line 6
Caused by I28d4e41437e485e518f2a23b6da00cdc430a8c23 There is https://gerrit.wikimedia.org/r/#/c/121046/ but I doubt it's appropriate to break compatibility like this, opinions? I left it in MediaWiki>General for now.
Change 121046 had a related patch set uploaded by Nemo bis: Update beginRecentChangesList to fix php strict standard notice https://gerrit.wikimedia.org/r/121046
Change 121046 abandoned by Aude: Update beginRecentChangesList to fix php strict standard notice https://gerrit.wikimedia.org/r/121046
ebernhardson: Could you take a look at this please? Patch abandoned (considered wrong place); resetting bug status to NEW.
Reverted: I1851e23e186ba7aaeb001ba212e56888657a3ae0 Technically fixed, can stay open until Erik and Matthias have a chance to comment on what other path they'll take.
(In reply to Nemo from comment #5) > Reverted: I1851e23e186ba7aaeb001ba212e56888657a3ae0 > Technically fixed, can stay open until Erik and Matthias have a chance to > comment on what other path they'll take. I'd suggest having working defaults when adding parameters to a function. AFAIK this is common practice.
Taking another stab at this, next implementation is If74ae600ffba949364dd381dd3d466cbbaa27286 which shouldn't effect any existing implementations or consumers.
This looks rather fixed to me, marking as such.