Last modified: 2014-04-17 20:23:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65108, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63108 - Declaration of NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res)
Declaration of NCL::beginRecentChangesList() should be compatible with Enhanc...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
1.23.0
All All
: High major (vote)
: 1.23.0 release
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks: 39480
  Show dependency treegraph
 
Reported: 2014-03-26 13:16 UTC by Nemo
Modified: 2014-04-17 20:23 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2014-03-26 13:16:20 UTC
We're currently flooded by dozens of these per minute:

13.36 -rakkaus:#mediawiki-i18n- (10 lines skipped) [26-Mar-2014 12:36:16 UTC] PHP Strict Standards:  Declaration of
          NCL::beginRecentChangesList() should be compatible with EnhancedChangesList::beginRecentChangesList($res) in
          /www/translatewiki.net/w/extensions/CleanChanges/CleanChanges_body.php on line 6
Comment 1 Nemo 2014-03-26 13:17:50 UTC
Caused by I28d4e41437e485e518f2a23b6da00cdc430a8c23
There is https://gerrit.wikimedia.org/r/#/c/121046/ but I doubt it's appropriate to break compatibility like this, opinions? I left it in MediaWiki>General for now.
Comment 2 Gerrit Notification Bot 2014-03-26 13:18:51 UTC
Change 121046 had a related patch set uploaded by Nemo bis:
Update beginRecentChangesList to fix php strict standard notice

https://gerrit.wikimedia.org/r/121046
Comment 3 Gerrit Notification Bot 2014-03-26 13:30:20 UTC
Change 121046 abandoned by Aude:
Update beginRecentChangesList to fix php strict standard notice

https://gerrit.wikimedia.org/r/121046
Comment 4 Andre Klapper 2014-03-26 13:48:37 UTC
ebernhardson: Could you take a look at this please?

Patch abandoned (considered wrong place); resetting bug status to NEW.
Comment 5 Nemo 2014-03-26 14:43:15 UTC
Reverted: I1851e23e186ba7aaeb001ba212e56888657a3ae0
Technically fixed, can stay open until Erik and Matthias have a chance to comment on what other path they'll take.
Comment 6 Siebrand Mazeland 2014-03-26 17:35:11 UTC
(In reply to Nemo from comment #5)
> Reverted: I1851e23e186ba7aaeb001ba212e56888657a3ae0
> Technically fixed, can stay open until Erik and Matthias have a chance to
> comment on what other path they'll take.

I'd suggest having working defaults when adding parameters to a function. AFAIK this is common practice.
Comment 7 Erik Bernhardson 2014-03-26 18:34:32 UTC
Taking another stab at this, next implementation is If74ae600ffba949364dd381dd3d466cbbaa27286 which shouldn't effect any existing implementations or consumers.
Comment 8 Bartosz Dziewoński 2014-04-17 20:23:50 UTC
This looks rather fixed to me, marking as such.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links