Last modified: 2014-09-22 14:35:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64337, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62337 - OOjs UI: Buttons and button-like things should be keyboard-accessible
OOjs UI: Buttons and button-like things should be keyboard-accessible
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Alex Monk
: accessibility
: 58564 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-06 18:15 UTC by James Forrester
Modified: 2014-09-22 14:35 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2014-03-06 18:15:44 UTC 
'Cos right now they're not, which is bad and sad.
Comment 1 James Forrester 2014-04-01 19:26:31 UTC 
*** Bug 58564 has been marked as a duplicate of this bug. ***
Comment 2 Gerrit Notification Bot 2014-05-12 20:21:56 UTC 
Change 132979 had a related patch set uploaded by Jforrester:
Button accessibility

https://gerrit.wikimedia.org/r/132979
Comment 3 Gerrit Notification Bot 2014-05-14 18:46:22 UTC 
Change 132979 merged by jenkins-bot:
Button accessibility

https://gerrit.wikimedia.org/r/132979
Comment 4 Derk-Jan Hartman 2014-05-19 08:47:25 UTC 
Far from fixed.

oo-ui-tool-link's for help and edit notices, should have tabIndex=0 and role=button to make them a focusable elements and they need labels to describe them (aria-label[ledby]). The page options groups is a total wash in terms of keyboard accessibility.
Comment 5 James Forrester 2014-06-26 23:21:03 UTC 
I think this is now done given bug 65473's resolution.
Comment 6 Alex Monk 2014-06-27 22:03:25 UTC 
(In reply to Derk-Jan Hartman from comment #4)
> oo-ui-tool-link's for help and edit notices, should have tabIndex=0 and
> role=button to make them a focusable elements and they need labels to
> describe them (aria-label[ledby]). The page options groups is a total wash
> in terms of keyboard accessibility.

Do we have all of this then? That's definitely not all covered by bug 65474
Comment 7 Alex Monk 2014-06-30 18:46:59 UTC 
Apparently not.
Comment 8 Gerrit Notification Bot 2014-06-30 21:13:23 UTC 
Change 143155 had a related patch set uploaded by Alex Monk:
Add tabindex=0 and role=button to tool links

https://gerrit.wikimedia.org/r/143155
Comment 9 Gerrit Notification Bot 2014-07-01 22:04:20 UTC 
Change 143155 merged by jenkins-bot:
Add tabindex=0 and role=button to tool links

https://gerrit.wikimedia.org/r/143155
Comment 10 Alex Monk 2014-07-02 17:04:39 UTC 
(In reply to Derk-Jan Hartman from comment #4)
> they need labels to describe them (aria-label[ledby]).

Hey. Could you explain this a bit more please?
Comment 11 Alex Monk 2014-07-24 21:41:36 UTC 
Derk-Jan?
Comment 12 Bartosz Dziewoński 2014-09-22 14:35:50 UTC 
I think we should close this and open separate bugs for any remaining issues. It seems that the buttons in question (comment 4 and comment 10) are already described by a 'title' attribute, which may not be ideal but is still something. More precise label would probably have to be added in VE, not OOjs UI.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links