Last modified: 2014-03-26 18:50:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63807, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61807 - Raw edit links on file description pages
Raw edit links on file description pages
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
https://en.m.wikipedia.org/wiki/File:...
:
Depends on: 19415
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-22 17:35 UTC by Max Semenik
Modified: 2014-03-26 18:50 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Comment 1 Bingle 2014-02-24 18:00:29 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1723
Comment 2 Jon 2014-02-27 19:57:43 UTC 
The raw edit links actually will redirect to the appropriate editor.
They do look ugly and should be handled like every other link though.
What creates them exactly - it looks like some code specific to the magic commons code...
Comment 3 Max Semenik 2014-02-27 21:39:07 UTC 
(In reply to Jon from comment #2)
> The raw edit links actually will redirect to the appropriate editor.

No they will not - because they're leading to Commons. This happens because we process our own parse results to redo the edit links our way, however we can't influence whatever we're receiving from Commons. Let's just hide them with CSS.
Comment 4 Jon 2014-02-27 21:56:16 UTC 
No I understand what I am saying is if you are logged in on Commons
https://commons.m.wikimedia.org/w/index.php?title=File:Euromaidan_in_Kiev_2014-02-19_12-06.jpg&action=edit&section=2
will take you to the appropriate edit section. (try it)

What I am asking is what creates it. I suspect these are being generating in a hacky way and we can cut them off at the source.
Comment 5 Max Semenik 2014-02-27 22:13:24 UTC 
See comment #3 for explanation. It makes a lot of sense to do just like core does and not show edit links from shared repo at all.
Comment 6 Gerrit Notification Bot 2014-02-27 22:59:36 UTC 
Change 115995 had a related patch set uploaded by MaxSem:
Suppress edit links from a remote repository on file pages

https://gerrit.wikimedia.org/r/115995
Comment 7 Gerrit Notification Bot 2014-03-12 10:31:25 UTC 
Change 115995 abandoned by MaxSem:
Suppress edit links from a remote repository on file pages

https://gerrit.wikimedia.org/r/115995
Comment 8 Jon 2014-03-19 18:25:34 UTC 
Blocked on bug 19415
Comment 9 Bartosz Dziewoński 2014-03-26 18:48:49 UTC 
The links in question have been nuked per bug 19415.
Comment 10 Jon 2014-03-26 18:50:44 UTC 
Thanks Bartosz for updating this bug report!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links