Last modified: 2014-07-14 18:05:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63646, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61646 - WikimediaEvents should pass jshint
WikimediaEvents should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikimediaEvents (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks: jshint
  Show dependency treegraph
 
Reported: 2014-02-20 13:53 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-07-14 18:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:53:57 UTC
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-02-20 17:40:13 UTC
Change 114500 had a related patch set uploaded by Mattflaschen:
Fix jshint by noting global requirement for VE file

https://gerrit.wikimedia.org/r/114500
Comment 2 Gerrit Notification Bot 2014-02-20 19:24:59 UTC
Change 114500 merged by jenkins-bot:
Fix jshint by noting global requirement for VE file

https://gerrit.wikimedia.org/r/114500
Comment 3 Gerrit Notification Bot 2014-02-20 19:34:45 UTC
Change 114519 had a related patch set uploaded by Mattflaschen:
Make jshint voting for WikimediaEvents

https://gerrit.wikimedia.org/r/114519
Comment 4 Gerrit Notification Bot 2014-02-20 20:03:41 UTC
Change 114519 merged by jenkins-bot:
Make jshint voting for WikimediaEvents

https://gerrit.wikimedia.org/r/114519
Comment 5 Antoine "hashar" Musso (WMF) 2014-02-20 20:04:26 UTC
Well done! Thank you very much :-]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links