Last modified: 2014-02-20 14:42:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63634, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61634 - SemanticResultFormats should pass jshint
SemanticResultFormats should pass jshint
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
SemanticResultFormats (Other open bugs)
master
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint
  Show dependency treegraph
 
Reported: 2014-02-20 13:48 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-02-20 14:42 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:48:30 UTC
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 MWJames 2014-02-20 13:57:40 UTC
I'm guessing this will not happen soon as there are several external libraries used and while those can be exempted, someone obviously has to do this.

Unless a volunteer finds the time to dig through the resources and make an effort to clear up the jshint/jslint issues, it consequently means that those will probably persist for some time to come.
Comment 2 Antoine "hashar" Musso (WMF) 2014-02-20 14:42:12 UTC
Seems third party libraries are ignored already:

$ cat .jshintignore 
# jQuery third-party libs
resources/jquery/

# other third-party libs
formats/Exhibit
formats/JitGraph
formats/timeline/resources/SimileTimeline
$

That is a good start :-]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links