Last modified: 2014-09-17 14:10:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63631, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61631 - SemanticFormsInputs should pass jshint
SemanticFormsInputs should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticFormsInputs (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: s7eph4n
:
Depends on:
Blocks: jshint
  Show dependency treegraph
 
Reported: 2014-02-20 13:47 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-09-17 14:10 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:47:22 UTC
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-03-28 15:42:47 UTC
Change 121679 had a related patch set uploaded by Jatin:
making js files pass jshint

https://gerrit.wikimedia.org/r/121679
Comment 2 Jatin 2014-03-28 19:34:45 UTC
Hi Antoine "hashar" Musso,

I have submitted a patch to this bug, please review the changes and validate them.
Comment 3 Antoine "hashar" Musso (WMF) 2014-03-28 21:54:36 UTC
My Javascript is very limited, you might want to add as reviewers folks that write the code / maintain the extension :-)
Comment 4 Gerrit Notification Bot 2014-08-30 19:49:52 UTC
Change 121679 merged by Foxtrott:
making js files pass jshint test

https://gerrit.wikimedia.org/r/121679
Comment 5 Gerrit Notification Bot 2014-09-17 14:10:08 UTC
Change 160962 had a related patch set uploaded by Hashar:
SemanticFormsInputs pass jshint, make it voting

https://gerrit.wikimedia.org/r/160962
Comment 6 Gerrit Notification Bot 2014-09-17 14:10:31 UTC
Change 160962 merged by jenkins-bot:
SemanticFormsInputs pass jshint, make it voting

https://gerrit.wikimedia.org/r/160962
Comment 7 Antoine "hashar" Musso (WMF) 2014-09-17 14:10:54 UTC
I have updated Zuul to -2 whenever jshint is not passing. Thank you!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links