Last modified: 2014-02-20 14:38:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63619, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61619 - ProofreadPage should pass jshint
ProofreadPage should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Tpt
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-02-20 13:41 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-02-20 14:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:41:11 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Tpt 2014-02-20 14:18:53 UTC 
I believe that I720b613f48ce29d4b63e4a4cd5c1c38bc351c4de fix the issues with jshint.
Comment 2 Gerrit Notification Bot 2014-02-20 14:31:32 UTC 
Change 114463 had a related patch set uploaded by Hashar:
Improves JavaScript code quality

https://gerrit.wikimedia.org/r/114463
Comment 3 Gerrit Notification Bot 2014-02-20 14:34:21 UTC 
Change 114463 merged by jenkins-bot:
Improves JavaScript code quality

https://gerrit.wikimedia.org/r/114463
Comment 4 Gerrit Notification Bot 2014-02-20 14:36:26 UTC 
Change 114465 had a related patch set uploaded by Hashar:
mwext-ProofreadPage-jslint is now voting

https://gerrit.wikimedia.org/r/114465
Comment 5 Gerrit Notification Bot 2014-02-20 14:36:46 UTC 
Change 114465 merged by jenkins-bot:
mwext-ProofreadPage-jslint is now voting

https://gerrit.wikimedia.org/r/114465
Comment 6 Antoine "hashar" Musso (WMF) 2014-02-20 14:38:47 UTC 
Thank you!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links