Last modified: 2014-07-24 08:21:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63617, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61617 - OATHAuth should pass jshint
OATHAuth should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OATHAuth (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-02-20 13:40 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-07-24 08:21 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:40:24 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Alex Monk 2014-07-07 17:26:12 UTC 
These look like upstream files... Do we just want to exclude those from the checks?
Comment 2 Antoine "hashar" Musso (WMF) 2014-07-21 12:31:12 UTC 
Apparently modules/qrcode.js is a third party file so it could be added to .jshintignore

modules/jquery.qrcode.js seems to have been written by Ryan Lane.
Comment 3 Gerrit Notification Bot 2014-07-21 12:34:02 UTC 
Change 148059 had a related patch set uploaded by Hashar:
Pass jshint

https://gerrit.wikimedia.org/r/148059
Comment 4 Gerrit Notification Bot 2014-07-24 05:23:01 UTC 
Change 148059 merged by jenkins-bot:
Pass jshint

https://gerrit.wikimedia.org/r/148059
Comment 5 Gerrit Notification Bot 2014-07-24 08:19:44 UTC 
Change 148963 had a related patch set uploaded by Hashar:
Make OATHAuth jslint job voting

https://gerrit.wikimedia.org/r/148963
Comment 6 Gerrit Notification Bot 2014-07-24 08:20:10 UTC 
Change 148963 merged by jenkins-bot:
Make OATHAuth jslint job voting

https://gerrit.wikimedia.org/r/148963
Comment 7 Antoine "hashar" Musso (WMF) 2014-07-24 08:21:05 UTC 
Jenkins job is now voting. \O/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links