Last modified: 2014-03-29 10:00:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63611, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61611 - [upstream] Maps should pass jshint
[upstream] Maps should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Maps (Other open bugs)
master
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks: jshint
  Show dependency treegraph
 
Reported: 2014-02-20 13:38 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-03-29 10:00 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:38:27 UTC
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Andre Klapper 2014-03-28 11:34:17 UTC
Jeroen: What's the reason to be actively against fixing this (WONTFIX)?
Comment 2 Jeroen De Dauw 2014-03-28 13:13:09 UTC
I do not interpret WONTFIX as being against it being fixed. If someone submits a PR doing so, that'd be great. If someone creates a new ticket with this issue, then that is also fine. However pointing to this one would be odd since it has stuff that no longer applies.

> one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 3 Andre Klapper 2014-03-28 13:31:24 UTC
(In reply to Jeroen De Dauw from comment #2)
> I do not interpret WONTFIX as being against it being fixed.

See [[mw:Bug management/Bug report life cycle]] for meanings; sounds like lowest priority then.
Comment 4 Antoine "hashar" Musso (WMF) 2014-03-28 14:32:17 UTC
Reopening as lowest priority. That should be fixed.
Comment 5 Jeroen De Dauw 2014-03-29 04:29:42 UTC
The Maps issue tracker is at https://github.com/JeroenDeDauw/Maps/issues

Reopen it there if you care to.
Comment 6 Antoine "hashar" Musso (WMF) 2014-03-29 09:18:42 UTC
Upstream bug: https://github.com/JeroenDeDauw/Maps/issues/28


(still can't believe how much time I am losing with you.
Comment 7 Jeroen De Dauw 2014-03-29 10:00:08 UTC
If you reopen, this this will jsut end up with having one open bug stick around forever. Now if you please can stop wasting my time by obstructing the migration of the bugs of the extension I created and maintain, that'd be very nice.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links